Ticket #1196 (closed bug: fixed)

Opened 5 years ago

Last modified 4 years ago

high speed feature dragging breaks sometimes

Reported by: tschaub Owned by: tschaub
Priority: minor Milestone: 2.8 Release
Component: Control.DragFeature Version: 2.5
Keywords: Cc:
State: Complete

Description

Occasionally, you can drag a feature and get a sequence (out, up, done) that makes onComplete be called with a null feature. This can be improved by removing the upFeature code from the DragFeature control. I think this is due to changes in the drag handler - but I need to look at it more to see if this upFeature code is actually necessary somewhere.

Attachments

DragFeature.patch Download (0.8 KB) - added by bjornharrtell 4 years ago.

Change History

Changed 5 years ago by crschmidt

  • milestone changed from 2.6 Release to 2.7 Release

Mass ticket move to 2.7 post dev meeting. If you are actively working on this task, please update this ticket with information and change the milestone to 2.6. At the time of the next IRC meeting (most likely 1-31-08), this will mean the ticket can *not* be brought back into 2.6 unless there is further feedback.

Changed 5 years ago by euzuro

  • milestone changed from 2.7 Release to 2.8 Release

Mass ticket move out of 2.7 in preparation for a release plan.

If you are actively working on this task, and think that you can help this ticket to get finished and closed by September 1, please move it back to 2.7.

Changed 4 years ago by crschmidt

  • milestone changed from 2.8 Release to 2.9 Release

Not touched in 2.7, bumping.

Changed 4 years ago by bjornharrtell

Changed 4 years ago by bjornharrtell

DragFeature.patch simply removes the line nulling the this.feature in upFeature, passing tests in Firefox. Less intrusive than the suggested fix which I guess requires more work investigating the consequences.

Changed 4 years ago by tschaub

  • milestone changed from 2.9 Release to 2.8 Release

I want to take a look at this for 2.8. We just need to make sure that the clickout stuff doesn't need the feature reference.

Changed 4 years ago by tschaub

  • status changed from new to assigned

Changed 4 years ago by tschaub

  • state set to Review

Changed 4 years ago by tschaub

Ok, I've played around with this and can't find any negative side effects. Tests still pass. Examples still work. It's still not apparent to me exactly where things fail (with fast dragging) - so this feels a big voodoo. But if it fixes a problem and we can't find negative side effects, then it is probably safe.

Changed 4 years ago by tschaub

  • status changed from assigned to closed
  • state changed from Review to Complete
  • resolution set to fixed

(In [9090]) Don't remove the drag control's reference to the feature on up. This is intended to solve issues with fast dragging. Thanks for the patch bjornharrtell. r=me (closes #1196)

Note: See TracTickets for help on using tickets.