ZoomBox control: add property mode with values zoomin/zoomout

[bartvde]

This would make it possible to easily have ESRI style zoomout controls, where the user can click or draw a box to zoom out. The smaller the box, the more the map will zoom out.

The proposal is to add a property named "mode" with possible values zoomin and zoomout, and a default value of zoomin so nothing will change for existing applications.

I will add a patch for this later.

[crschmidt]

I like the patch: I'm not sure if I like the names 'zoomin', 'zoomout'. Perhaps just 'in' and 'out', since we know it's a zoom control?

[bartvde]

Hi Chris, maybe then we should use direction instead of mode? So direction=in or direction=out? Let me know what you conclude on and I can change the patch.

[crschmidt]

Bart: Given no further feedback from anyone else, I'm happy with direction:in / direction:out. If you update the patch, I'll review again: thanks!

[bartvde]

Chris, I've updated the patch. Btw I changed "in" and "out" for direction in "forward" and "backward", which makes more sense as possible values for direction in the linguistic sense.

[tschaub]

I don't want to drag this one out, but I will say that string values strike me the wrong way for some reason. Elsewhere in the library, where we do have "mode" type properties, we typically use static (class) properties or constants as possible values (as in control.type = OpenLayers.Control.BUTTON). I can't really imagine many more modes for the zoom box, so it seems to me that a boolean is appropriate (as in control.out = true).

Don't know how others feel about this. I think for me it's about remembering as little as possible. If I want to make the zoom box go out, it makes sense that I'd set control.out to true (or maybe control.zoomout - but then I might forget if it is camel case or not). Anyway, I'm not strongly opinionated about this.

(Is it "forwards" or "forward" or maybe "foreword", is it "backwards" or "backward" or perhaps "backwoods"? A smart editor might help with OpenLayers.Control.BUTTON, but it's not going to lend a hand with the spelling of "backwords".)

[bartvde]

Tim, I agree, a boolean would suffice. I'll update the patch. I'll name the boolean out.

[pspencer]

Hi Bart,

in looking over the patch, I have a couple of suggestions that I would like to put forward.

* the zoom factor is only calculated from the width. I think it should be calculated from the width or height depending on which calculation yields a smaller result * the new bounding box is centered on the current center of the map, I think it should be centered on the zoom box.

Making these two changes should result in the old extent of the map being fit (more or less) into the area covered by the zoom box, which is the most logical interpretation of zooming out by a box that I can think of.

[bartvde]

Hey Paul. Good suggestions. I'll make the changes and update the patch.

[bartvde]

Paul, I've updated the patch with your suggestions, please review again. Thanks.

[pspencer]

reviewing ...

[pspencer]

Reviewed, the patch looks good to me, changing to commit (and committing)

[pagameba]

(In [5796]) (Closes #1187.) applying Bart's patch to add a zoom out option to the zoom control. r=pspencer.