New vector style property "display"

[ahocevar]

Attached is a very small patch that adds a style property "display" to vector feature style hashes. This property can be used to render a style hidden, so the feature will be invisible.

Technically speaking, features with style:display="none" will not be rendered at all. If there is a DOM node for the feature, it will be removed.

This property will be used by the upcoming styles framework to hide features that are outside the minScale/maxScale range

[crschmidt]

Hm. I'm slightly concerned about this, only because I'm worried about what happens if for some reason we have a selected feature that has its style switch to 'none' -- do I need to be worried? I'm not sure, but it's the first thing that comes to mind.

[ahocevar]

Replying to crschmidt:

Hm. I'm slightly concerned about this, only because I'm worried about what happens if for some reason we have a selected feature that has its style switch to 'none' -- do I need to be worried? I'm not sure, but it's the first thing that comes to mind.

You do not need to worry. The only thing that will happen is that the feature will disappear on select, but you can still use e.g. OpenLayers.Control.SelectFeature.unselect to unselect it.

[elemoine]

Thanks Andreas. I'm in favor for your patch.

Note that I have tests for this patch, based on pgiraud's tests for the renderers (#1128). They also rely on my fix to test_Elements.html (#1172). I'll attach a patch here once my patch for #1172 is applied to trunk.

[elemoine]

Replying to elemoine:

Thanks Andreas. I'm in favor for your patch. Note that I have tests for this patch, based on pgiraud's tests for the renderers (#1128). They also rely on my fix to test_Elements.html (#1172). I'll attach a patch here once my patch for #1172 is applied to trunk.

oops, my patch to test_Elements.html is in #1184, not in #1172. Sorry for the confusion.

[ahocevar]

Updated patch against r5342.

[crschmidt]

elemoine: #1184 is in, do you still have tests for this?

[crschmidt]

If we can get some tests in, I'm fine with this being committed. Eric, please pull your tests in, then go ahead and commit when you feel comfortable with it.

[elemoine]

Will do. But I'm in the office right now and I left the patch at home :-)

[elemoine]

Andreas' patch + tests

[elemoine]

I attached a patch that includes tests. I'll test it tomorrow again and commit it if all tests pass on FF and IE.

[ahocevar]

Fixed patch, successfully tested in FF2 and IE6.

[ahocevar]

Eric, there was a minor problem in test_Elements.js. Attached patch-1173-r5535-A0.diff. Tests pass in FF2 and IE6.

[elemoine]

(In [5541]) Add style property "display" to vector feature style. If display is "none" the feature won't be rendered and there's a DOM node for that feature it'll be removed. Commiting this on behalf of ahocevar. Thanks Andreas for the patch. r=crschmidt. (closes #1173).