Ticket #1140 (closed feature: fixed)
unused code in Renderer.Elements eraseGeometry method
| Reported by: | pgiraud | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 2.6 Release |
| Component: | Renderer.Elements | Version: | 2.5 |
| Keywords: | Cc: | ||
| State: |
Description
In the Renderer.Elements eraseGeometry method, we test if element.geometry exist to destroy this objet.
var element = OpenLayers.Util.getElement(geometry.id);
if (element && element.parentNode) {
if (element.geometry) {
element.geometry.destroy();
element.geometry = null;
}
element.parentNode.removeChild(element);
}
But I didn't find any case where element.geometry exists. It would mean that we had given a DOM element a reference to a geometry object somewhere. But it seems, that this isn't done anywhere because the DOM element already shares its id attribute with the geometry. It doesn't have to know anything about the geometry object.
Moreover, we don't really want to destroy the geometry because it can actually be used by another feature.
In my opinion, this snippet of code is pretty much useless.
All tests pass on FF (linux) and IE 6. So do acceptance tests.
Attachments
Change History
Note: See
TracTickets for help on using
tickets.

