Ticket #1140 (closed feature: fixed)

Opened 6 years ago

Last modified 6 years ago

unused code in Renderer.Elements eraseGeometry method

Reported by: pgiraud Owned by:
Priority: minor Milestone: 2.6 Release
Component: Renderer.Elements Version: 2.5
Keywords: Cc:
State:

Description

In the Renderer.Elements eraseGeometry method, we test if element.geometry exist to destroy this objet.

            var element = OpenLayers.Util.getElement(geometry.id);
            if (element && element.parentNode) {
                if (element.geometry) {
                    element.geometry.destroy();
                    element.geometry = null;
                }
                element.parentNode.removeChild(element);
            }

But I didn't find any case where element.geometry exists. It would mean that we had given a DOM element a reference to a geometry object somewhere. But it seems, that this isn't done anywhere because the DOM element already shares its id attribute with the geometry. It doesn't have to know anything about the geometry object.

Moreover, we don't really want to destroy the geometry because it can actually be used by another feature.

In my opinion, this snippet of code is pretty much useless.

All tests pass on FF (linux) and IE 6. So do acceptance tests.

Attachments

eraseGeometry.patch Download (0.6 KB) - added by pgiraud 6 years ago.
removes unused code

Change History

Changed 6 years ago by pgiraud

removes unused code

Changed 6 years ago by tschaub

  • status changed from new to closed
  • resolution set to fixed

(In [5397]) remove unused code that referred to element.geometry - thanks for catching this pgiraud - I missed it in r3043 (closes #1140).

Note: See TracTickets for help on using tickets.