Ticket #1119 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

WFS format creates bad delete transactions

Reported by: tschaub Owned by: tschaub
Priority: minor Milestone: 2.6 Release
Component: Format.WFS Version: 2.5
Keywords: Cc:
State:

Description

The WFS format checks for feature.attributes.fid instead of feature.fid when creating a delete node. This is wrong. Thanks to tcoulter for catching this.

Attachments

wfst.patch Download (1.1 KB) - added by tschaub 6 years ago.
improve delete transactions

Change History

Changed 6 years ago by tschaub

improve delete transactions

Changed 6 years ago by tschaub

  • keywords review added

Please review.

Changed 6 years ago by elemoine

  • keywords commit added; review removed

Tim, thanks for the patch. Please commit.

Just realized we don't have tests for Format.WFS. And on an unrelated note, I noticed we also don't have tests for the renderers. I hope to find time to improve the test coverage situation.

Changed 6 years ago by tschaub

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

(In [5113]) give wfs delete transactions the correct feature.fid - thanks for the review elemoine (closes #1119).

Note: See TracTickets for help on using tickets.