handlers have to check if layer exists before destroying it

[pgiraud]

Handler.Point and Handler.RegularPolygon deal with a layer and in some cases they try to call removeLayer() or destroy() even if it is already destroyed. This happens for example when the map is destroyed.

Handlers should check if layer is destroyed.

In the same way, I also remove the call to removeLayer as the destroy method already do this.

Patch (with tests !) forthcoming.

[pgiraud]

patch with tests

[pgiraud]

please review

[pgiraud]

I can confirm that all tests pass on IE6 win and FF linux.

[elemoine]

Replying to pgiraud:

I can confirm that all tests pass on IE6 win and FF linux.

I'm in favour for this patch.

Just one comment though: you use layer.map to check whether the layer was destroyed or not. Rigorously, layer.map == null doesn't mean that the layer was destroyed, it means that the layer isn't added to the map. In the Handler.Point and Handler.RegularPolygon cases, we're assured that the layer was destroyed if layer.map is null bause the handlers themselves call addLayer(). For other cases, I think we should introduce a destroyed property and possibly a isDestroyed() method to the Layer class.

[elemoine]

Pierre's patch + comments added

[elemoine]

(In [5085]) handlers have to check if layer exists before destroying it. Thanks pgiraud. (closes #1107)