Ticket #1076 (closed task: fixed)

Opened 6 years ago

Last modified 4 years ago

Remove unused 'tileOrigin' code from TileCache layer

Reported by: euzuro Owned by: crschmidt
Priority: minor Milestone: 2.8 Release
Component: Layer.TileCache Version: 2.5 RC5
Keywords: Cc:
State: Complete

Description

seems to me like 'tileOrigin' is not used. Let's remove it.

Attachments

tileOrigin.patch Download (1.2 KB) - added by euzuro 6 years ago.

Change History

Changed 6 years ago by euzuro

Changed 6 years ago by euzuro

...or perhaps (as suggested by cr5) we actually *do* need that 'tileOrigin' and should instead investigate actually using it.

Changed 5 years ago by crschmidt

  • state set to Needs Discussion

Changed 5 years ago by tschaub

I think I put it there because I wanted TC to have a configurable tileOrigin - or perhaps it already does. Maybe it was because I wanted OL to have a configurable tileOrigin. Anyway, I think tileOrigin is a good idea. Whether or not it belongs in this class, I can't say right now. Since it is there, and I'm trying to shorten my list of responsibilities, I'm going to close this unless it gets other feedback in a day or two.

Changed 5 years ago by crschmidt

  • owner changed from tschaub to crschmidt
  • milestone changed from 2.6 Release to 2.7 Release

Changed 5 years ago by euzuro

  • milestone changed from 2.7 Release to 2.8 Release

Mass ticket move out of 2.7 in preparation for a release plan.

If you are actively working on this task, and think that you can help this ticket to get finished and closed by September 1, please move it back to 2.7.

Changed 4 years ago by crschmidt

  • status changed from new to closed
  • state changed from Needs Discussion to Complete
  • resolution set to fixed

(In [8930]) "Remove unused 'tileOrigin' code from TileCache layer", (Closes #1076). Though the idea behind this is good, having the code here and unused is not the right thing to do. (See #1302) for a better attempt at what this should actually be. The reason this code exists is almost certainly a carggocult from Layer.TMS, which *does* have a tileOrigin, and I'm pretty sure tschaub started by copying from that. r=me, though it's mostly just docs.

Note: See TracTickets for help on using tickets.