Ticket #1067 (closed bug: fixed)

Opened 6 years ago

Last modified 5 years ago

GeoJSON should serialize geometry.collection as GeometryCollection and vice-versa

Reported by: tschaub Owned by: tschaub
Priority: minor Milestone:
Component: Format.GeoJSON Version: 2.5 RC5
Keywords: Cc:
State: Complete

Description

The GeoJSON spec describes GeometryCollection as a type of geometry, not a collection of geometries.

Attachments

collection.patch Download (16.2 KB) - added by tschaub 6 years ago.
parse GeometryCollection as geometry.collection
geojson.patch Download (19.7 KB) - added by crschmidt 6 years ago.
a rendered example, and another test

Change History

Changed 6 years ago by tschaub

parse GeometryCollection as geometry.collection

Changed 6 years ago by crschmidt

a rendered example, and another test

Changed 6 years ago by crschmidt

The patch looks good to me. I'm okay having this go into trunk. I don't want another RC just for this -- so the question then becomes if we can convince ourselves that we can put it in to the final release without another RC. I don't have a strong feeling against that, other than it being somewhat bad policy, especially since this is a rather invasive change.

I'd rather do a 2.5.1 to fix just GeoJSON after the spec is actually finished than try to chase it as part of a release. This could change again if the community fights against it.

Changed 5 years ago by crschmidt

  • status changed from new to closed
  • state set to Complete
  • resolution set to fixed

(In [5435]) GeoJSON should parse and serialize GeometryCollections as a Geometry.Collection object. (Closes #1067)

Changed 5 years ago by tschaub

(In [5436]) non-functional change - just removing an extra comma from r5435 to appease IE (see #1067)

Changed 5 years ago by tschaub

  • status changed from closed to reopened
  • resolution fixed deleted

Those extra two tests are broken. The format reads to an array of features by default. Clear cache before testing perhaps?

Changed 5 years ago by tschaub

  • status changed from reopened to closed
  • resolution set to fixed

(In [5437]) Fixed test for GeoJSON collections (closes #1067).

Note: See TracTickets for help on using tickets.