Ticket #1062 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

geojson format breaks on CRS changes

Reported by: crschmidt Owned by: tschaub
Priority: minor Milestone: 2.5 Release
Component: Format.GeoJSON Version: 2.5 RC4
Keywords: Cc:
State:

Description

GeoJSON CRS changes break GeoJSON format

Attachments

geojson.patch Download (1.9 KB) - added by crschmidt 6 years ago.
geojson.2.patch Download (3.4 KB) - added by crschmidt 6 years ago.
geojson.3.patch Download (3.3 KB) - added by crschmidt 6 years ago.
patch not dependant on test ordering
geojson.4.patch Download (3.6 KB) - added by crschmidt 6 years ago.
also update docs

Change History

Changed 6 years ago by crschmidt

Changed 6 years ago by crschmidt

Changed 6 years ago by crschmidt

  • keywords review added

Second patch has tests.

Changed 6 years ago by crschmidt

The reason this wasn't caught in testing is because the GeoJSON features being serialized didn't have layers. WIth no layers, there is in projection object, so the GeoJSON parser doesn't do any CRS anything. When you add a layer, it breaks. This patch fixes that, and adds tests to ensure it doesn't break again.

Changed 6 years ago by crschmidt

Tests pass for me in IE6 and FF

Changed 6 years ago by crschmidt

patch not dependant on test ordering

Changed 6 years ago by crschmidt

IE7 ran tests differently ordered on me, so this patch doesn't depend on ordering. rerunning tests in FF, IE6, IE7 now

Changed 6 years ago by crschmidt

Tests all passing in IE6, IE7, FF.

Changed 6 years ago by crschmidt

also update docs

Changed 6 years ago by euzuro

  • keywords commit added; review removed

looks good. please insert, mark pullup, dance.

Changed 6 years ago by crschmidt

  • keywords pullup added; commit removed

(In [4819]) The createCRSObject stuff never really worked. Unfortunately, the tests didn't catch it because they were all minimal unit tests -- so they never hooked up features to layers with projections. This fixes the createCRSObject function, including updated documentation, and includes tests for regression. (Pullup #1062)

Changed 6 years ago by crschmidt

  • keywords pullup removed
  • status changed from new to closed
  • resolution set to fixed

(In [4830]) Pullup r4819 from trunk: fixing GeoJSON serializer breakage caused by draft4 update. (Closes #1062)

Note: See TracTickets for help on using tickets.