Ticket #1051 (closed bug: fixed)

Opened 6 years ago

Last modified 5 years ago

Improve reslience of getStyle

Reported by: crschmidt Owned by: elemoine
Priority: major Milestone: 2.7 Release
Component: Util Version: SVN
Keywords: Cc:
State: Complete

Description

getStyle can bomb when passed nulls. Fix that.

Attachments

getStyle_safe.patch Download (2.8 KB) - added by euzuro 5 years ago.
how about this? ((or should this patch include the propsed chanes to getPagePosition() or whatever it's called function))
getStyle_safe.2.patch Download (3.6 KB) - added by euzuro 5 years ago.
take two of the safing of getStyle -- this patch includes the fix in pagePosition() function

Change History

Changed 6 years ago by crschmidt

When we fix this, we can rmeove the workaround in OpenLayers.Util.pagePosition.

Changed 6 years ago by euzuro

Please see #1034

Changed 6 years ago by crschmidt

r4783

Changed 5 years ago by crschmidt

  • milestone changed from 2.6 Release to 2.7 Release

Mass ticket move to 2.7 post dev meeting. If you are actively working on this task, please update this ticket with information and change the milestone to 2.6. At the time of the next IRC meeting (most likely 1-31-08), this will mean the ticket can *not* be brought back into 2.6 unless there is further feedback.

Changed 5 years ago by euzuro

how about this? ((or should this patch include the propsed chanes to getPagePosition() or whatever it's called function))

Changed 5 years ago by euzuro

  • owner set to euzuro
  • status changed from new to assigned

Changed 5 years ago by crschmidt

  • milestone changed from 2.7 Release to 2.8 Release

Changed 5 years ago by crschmidt

  • milestone changed from 2.8 Release to 2.7 Release

Changed 5 years ago by euzuro

take two of the safing of getStyle -- this patch includes the fix in pagePosition() function

Changed 5 years ago by euzuro

  • owner euzuro deleted
  • status changed from assigned to new
  • state set to Review

tests pass on FF2, IE7. Please review.

Changed 5 years ago by elemoine

I think #1675 should be looked at and committed to trunk before that one.

Changed 5 years ago by euzuro

(#1675 has changes to Elements.js and is a big patch so better to let it go in first, then adapt this one than vice-versa)

Changed 5 years ago by euzuro

  • owner set to elemoine

on a second glance, it turns out we are talking about two different Element.js's. Carry on, carry on.

Changed 5 years ago by crschmidt

  • state changed from Review to Commit

easy peasy fresh and squeezy. go for it. thanks, big e

Changed 5 years ago by euzuro

  • status changed from new to closed
  • state changed from Commit to Complete
  • resolution set to fixed

(In [7888]) improving the biceps of getStyle(). Now if you pass it a null object, it will not die. r=cr5 (Closes #1051)

Note: See TracTickets for help on using tickets.