Ticket #1044 (closed feature: fixed)

Opened 6 years ago

Last modified 6 years ago

KML should automatically determine NS

Reported by: crschmidt Owned by: tschaub
Priority: minor Milestone: 2.5 Release
Component: Format.KML Version: 2.5 RC3
Keywords: Cc:
State:

Description

With three different KML namespaces floating about, the KML layer should have support for automatically determining the KML namespace version in use.

If we don't do this, I forsee a lot of problems as more users start using the KML layer.

Attachments

kml_ns.patch Download (4.5 KB) - added by crschmidt 6 years ago.

Change History

Changed 6 years ago by crschmidt

Changed 6 years ago by crschmidt

Search all nodes for Placemarks. once we have placemarks, store the namespaceURI from the node if it exists, and use that to parse the rest of the document.

The default namespace for output is still 2.0. All tests continue to pass, and new tests have been added.

Changed 6 years ago by crschmidt

  • keywords review added

Changed 6 years ago by sderle

  • keywords commit added; review removed

This patch seems fine, but what if a user wants to set the kmlns manually in code? I don't see it as a blocker if they can't for now, so please commit.

Changed 6 years ago by crschmidt

I can't imagine a way in which that would make sense. I'm going with this for 2.5RC4, and we can revisit later if it comes up again.

Changed 6 years ago by crschmidt

  • keywords commit removed
  • status changed from new to closed
  • resolution set to fixed

(In [4798]) Pullup for KML needs to automatically determine the namespace of the document it is handling. (Closes #1044)

Note: See TracTickets for help on using tickets.