Ticket #103 (closed feature: fixed)

Opened 7 years ago

Last modified 6 years ago

attribution and copyright field

Reported by: anonymous & jrf Owned by: euzuro
Priority: major Milestone: 2.5 Release
Component: Map Version:
Keywords: Cc: penyaskito@…
State:

Description (last modified by jrf) (diff)

To make it easy for proprietary data licensees to present the data they have bought in OpenLayers.Layer directly, e.g. by using the WMS layer or an adaptation of that to their own tiling scheme, we need to add methods of obeying the attribution and copyright requirements of these data sources. Typically a line of text at the bottom of the map window is sufficient.

Since maps contain many layers, the attribution text must be able to handle additions from many layers -- gracefully! The attribution text should also allow HTML so that it can contain hyperlinks, bolding, © etc.

A key requirement for most of the data providers that require attribution text is that it be visible when someone takes a screenshot. That means that the attribution text can disappear when data from that layer is not visible.

Attachments

Attribution.patch Download (5.3 KB) - added by openlayers 6 years ago.
A patch for adding the copyright text to each layer
103.patch Download (7.4 KB) - added by crschmidt 6 years ago.
103.2.patch Download (7.6 KB) - added by euzuro 6 years ago.
coding standards, adding some documentation bits and also rearranging the functions in the new control. no functional diff. you like?
103.3.patch Download (3.2 KB) - added by crschmidt 6 years ago.

Change History

Changed 7 years ago by euzuro

  • milestone 2.1 Release deleted

Changed 6 years ago by sderle

  • milestone set to 2.5 Release

Changed 6 years ago by openlayers

A patch for adding the copyright text to each layer

Changed 6 years ago by openlayers

  • cc penyaskito@… added
  • keywords review added

Changed 6 years ago by jrf

  • description modified (diff)
  • reporter changed from anonymous to anonymous & jrf

Changed 6 years ago by crschmidt

  • owner changed from sderle to metacarta
  • priority changed from blocker to major

Changed 6 years ago by crschmidt

Erik --

Can you look at http://openlayers.org/pipermail/dev/2007-May/000705.html , which is blocking this, and let me know if this event can be dropped?

Changed 6 years ago by crschmidt

  • owner changed from metacarta to euzuro

Changed 6 years ago by crschmidt

Changed 6 years ago by euzuro

coding standards, adding some documentation bits and also rearranging the functions in the new control. no functional diff. you like?

Changed 6 years ago by euzuro

  • keywords review removed
  • status changed from new to closed
  • resolution set to fixed

(In [4231]) adding OpenLayers.Control.Attribution to the list of controls in the OL suite. includes example and tests. very nice. Thanks to pensyakito and cr5 for getting this together and complete. (Closes #103)

Changed 6 years ago by fredj

  • status changed from closed to reopened
  • resolution fixed deleted

 http://www.openlayers.org/dev/examples/attribution.html don't work for me.

On page load the attribution is correctly set but when I change the base layer with the layer switcher, the attribution is empty.

FF 2.0.0.6 on Linux

in source:trunk/openlayers/lib/OpenLayers/Control/Attribution.js line 69, layer.getVisibility() always return false (race condition ?)

Changed 6 years ago by fredj

and replace 'seperator' with 'separator'

Changed 6 years ago by crschmidt

Changed 6 years ago by crschmidt

  • keywords review added

fredj: nice catch.

Attached patch does both of these:

1. register for changebaselayer, since changelayer is only called in setBaseLayer *before* the layer has actually changed.

2. Fix speling. (That was intentional.)

Changed 6 years ago by crschmidt

  • keywords review removed
  • status changed from reopened to closed
  • resolution set to fixed

(In [4237]) FredJ reviewed my work here and said it solved the problem that he reopened 103 for (specifically, that baselayer changes always resulted in a null attribution string), and fixes spelling. This commit makes the attribution control work and stuff. (Closes #103)

Note: See TracTickets for help on using tickets.