Ticket #1003 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

drag handler doesn't reset properties on left or improperly modified mousedown

Reported by: tschaub Owned by: tschaub
Priority: minor Milestone: 2.5 Release
Component: Handler.Drag Version: 2.5 RC1
Keywords: Cc:
State:

Description

Open click.html. Click once to confirm you get an alert. Shift-drag a zoom box. Click again to see no alert. The drag handler is stopping all clicks where handler.start != handler.last. If a mousedown is right or doesn't match the handlers modifiers, then the start and last properties are left lingering from the last click (which was a drag, so start != last, so the handler will not allow propagation of this click).

Patch to follow.

Attachments

shift-drag.patch Download (3.5 KB) - added by tschaub 6 years ago.
reset properties on ignored mousedown

Change History

Changed 6 years ago by tschaub

reset properties on ignored mousedown

Changed 6 years ago by tschaub

  • keywords review added

Tests pass in IE/FF. Please review.

Changed 6 years ago by crschmidt

  • keywords commit added; review removed

Looks good. Please commit.

Changed 6 years ago by tschaub

(In [4400]) Make the drag handler tidy up after itself a bit more. This solves the click blocking after shift-drag issue (see #1003).

Changed 6 years ago by tschaub

  • keywords pullup added; commit removed

Changed 6 years ago by crschmidt

  • keywords pullup removed
  • status changed from new to closed
  • resolution set to fixed

(In [4432]) Pullup changes for RC3:

  • KML Examples broken (Closes #1001)
  • drag handler doesn't reset properties on left or improperly modified mousedown (Closes #1003)
  • Text nodes limited to 4096 in length (Closes #1006)
  • KML/GML Attribute CDATA Parsing (Closes #1007)
  • Control.MousePosition (Closes #1008)
Note: See TracTickets for help on using tickets.