mapscript.i are using C# keywords (string, in, out) as parameter causing SWIG compilation to fail.

[ykchoo@…]

Three problems identified when compiling mapscript.i using SWIG (1.3.21)

1) C# (csharp) keywords are being used as parameters: string, in, and out. The 
files generated using SWIG (1.3.21) will not compile because of the keywords. 
For example "char *string" parameter is generated as "string string". 
Solution: renaming parameters with the keywords or use "#ifdef SWIGCSHAR" ...

2) The latest SWIG(1.3.21) has a bug in handling methods returning a pointer. 
For example "int *foo()" will be converted to "href int foo()". This will not 
work because href can only be used when defining parameter. 
Solution: Add a #ifdef, i.e. 
   #ifndef SWIGCSHARP
   %include typemaps.i
   #endif

3) labelCacheMemberObj structure contain a member named string.
Solution: edit the generated labelCacheMember.cs file "string string" to 
something like "string strings". I'm not sure what's the impact if it is 
possible to rename the "string" member.

[sgillies@…]

It is good to see some action on the C# front.  I do not use the language
and do not have a .NET platform.  This means that I will require patches to
fix this bug.  I can merge the patches and make sure that they don't break
the other language interfaces.  

Would you be able to provide patches?  Are you familiar with using CVS?

1) These parameter names are bad for many reasons.  I'll make a sweep through
the files and fix the obvious ones.  Then you could try again and give me
some patches.

2) I think I just read about this bug on the swig list.  Isn't using 1.3.19
the best solution for now?

3) There are a *lot* of poorly named structure members in mapserver.  I'll
look and see how much work is involved in changing the string member.

Some questions for you, since I am unfamiliar with C#.  Is "text" a reserved
word?

[sgillies@…]

OK, I just addressed part 1) in CVS HEAD and branch-4-2.  All my unit tests
pass.  Will await confirmation or a patch.

on 3 -- changing 'string' to 'labelstring' or such would involve edits to
5 or 6 files.  Not too bad, but I won't start on it until I get confirmation
on part 1.

[ykchoo@…]

Example of a patch

[sgillies@…]

yk, since I already finished the renaming before you submitted the file, I'm
going to reject your file.  The inclusion of typemaps.i is now conditional,
as in your file.  As a workaround for the labelCacheMemberObj, I am going to
hide this class from C# until bug 852 is fixed.  It is not an essential part
of mapscript.

I am attaching a new mapscript.i file as a .tar.gz.  Please test it and
confirm if it works.

[sgillies@…]

patched mapscript.i 4.2.3-1

[ykchoo@…]

Please note that patched mapscript.i 4.2.3-2 in BUG 848 fixes both C# and Java 
compilation errors. Thanks again for the quick response.

[sgillies@…]

Y.K. -- don't close the bug prematurely, you should leave that up to the
engineer working on the bug (me).  

[sgillies@…]

closed.