Memory leak with initialized class for embedded scalebars

[warmerdam]

To reproduce:

 cd msautotest/gdal
 shp2img -m rot_out.map -o out.png

Under valgrind this will report (amoung other things):

==2012== 440 bytes in 1 blocks are definitely lost in loss record 16 of 17
==2012==    at 0x400268D5: malloc (vg_replace_malloc.c:160)
==2012==    by 0x8053434: initClass (mapfile.c:1585)
==2012==    by 0x80B5C8F: msEmbedScalebar (mapscale.c:325)
==2012==    by 0x806F8E6: msDrawMap (mapdraw.c:328)
==2012==    by 0x804EABE: main (shp2img.c:159)

This seems to be due to there being no corresponding freeClass() for
the initClass() in msEmbedScalebar().   I don't know this stuff too well,
so I hesitate to try and fix it myself.

[sdlime]

I'll take care of this one...

Steve

[sdlime]

I think I found and fixed this one. Turns out the numclasses layer member was
never set so freeLayer never called freeClass. If you've got a test case handy
and could run it that would confirm the fix. I'll check the legend embedding
code too.

Steve