Ticket #590 (closed defect: fixed)

Opened 4 years ago

Last modified 2 months ago

Shape Index-Files (*.qix) not used when .shp extension is specified in mapfile

Reported by: ujunge@pmcentral.com Assigned to: sdlime
Priority: high Milestone: 5.2 release
Component: MapScript Version: 5.0
Severity: normal Keywords:
Cc: bartvde@osgis.nl, jmckenna

Description 

The Index-files (*.qix) of ESRI-Shape-Files are never used.

This behaviour has been verified using File-Auditing in W2000 
and has been observed for the builds  
  php_mapscript_40.dll from 8/5/2003
 and  
  php_mapscript_41.dll from 3/3/2004
(other builds have not been checked)

The only file-types accessed are the 3 standard-files (*.shx, *.shp, *.dbf)

I was wondering, why it maked never a difference (with respect to map-rendering 
time) wether qix-files are present or not.

Attachments

audit and directory listing.zip (2.5 kB) - added by ujunge@pmcentral.com on 03/10/04 15:28:54.
Audit and data directory listing
qixshp.patch (1.4 kB) - added by pramsey on 05/06/08 17:40:58.
Check for the .shp case and null terminate it prior to building filename
qixshp.2.patch (1.5 kB) - added by pramsey on 05/06/08 18:14:38.
Check for the .shp case and null terminate it prior to building filename

Change History

03/09/04 22:54:02 changed by sdlime

  • status changed from new to assigned.
I'd be really suprised if this is a real bug. The code in question is years old
and known to work. Let's start with the obvious. Are the filenames for the .qix
files correct, that is the same case as the shapefile with a lower-case extension?

Steve

03/10/04 15:28:54 changed by ujunge@pmcentral.com

  • attachment audit and directory listing.zip added.

Audit and data directory listing

07/27/04 13:35:21 changed by bartvde@osgis.nl 

Maybe slightly related, if you use the following DATA statement in a LAYER
definition:

DATA "myshapefile.shp"

Mapserver looks for myshapefile.shp.qix instead of myshapefile.qix.

So you should use DATA "myshapefile" instead to get it to use the index.

07/27/04 14:04:05 changed by bartvde@osgis.nl

  • cc set to bartvde@xs4all.nl.

11/23/04 10:48:44 changed by ummmmm@myrealbox.com 

I recently posted to the mailing list about severe performance problems that
turned out to be this same issue.  i.e. MapServer wasn't using our QIX files
because they were named incorrectly.  The documentation states that the .map
file DATA element can either specify or not specify the .shp extension, but
shptree creates .shp.qix if you use the extension, which MapServer doesn't find.

I suggested that at the least the documentation should warn of this problem
since we're not the first to make the mistake.  Mark Warmerdam suggested I open
a bug for the "qix name generator ought to deal with this more gracefully".  It
seems that this existing bug is a reasonable place to add the comment instead.

11/23/04 10:51:17 changed by ummmmm@myrealbox.com 

Oops - I specified the current behaviour backwards.  I guess shptree created
.qix, but MapServer was *looking* for .shp.qix because we had the .shp extension
specified in the .map file.

09/26/07 14:57:06 changed by jmckenna

  • cc changed from bartvde@osgis.nl to bartvde@osgis.nl, jmckenna.
  • version changed from 4.0 to 5.0.
  • summary changed from Shape Index-Files (*.qix) not used to Shape Index-Files (*.qix) not used when .shp extension is specified in mapfile.

09/26/07 15:11:44 changed by jmckenna

  • milestone set to 5.2 release.

05/06/08 17:40:58 changed by pramsey

  • attachment qixshp.patch added.

Check for the .shp case and null terminate it prior to building filename

05/06/08 18:14:38 changed by pramsey

  • attachment qixshp.2.patch added.

Check for the .shp case and null terminate it prior to building filename

05/07/08 00:13:52 changed by pramsey

  • status changed from assigned to closed.
  • resolution set to fixed.

Patched in trunk as of r7565. Patched in branch-5-0 as of r7566.

05/07/08 18:17:30 changed by jmckenna

verified!

man I've been waiting for this one a long time...i can't imagine how many users didn't know about this one.

i've also updated the doc with this note (http://mapserver.gis.umn.edu/docs/reference/utilityreference/shptree/)