Opened 13 years ago

Closed 13 years ago

#3821 closed defect (fixed)

Coding style issues in new rendering code

Reported by: dmorissette Owned by: dmorissette
Priority: normal Milestone: 6.0 release
Component: Renderer API Version: unspecified
Severity: normal Keywords:
Cc: tbonfort

Description

On a quick code review, I noticed some coding style issues in some of the new rendering code: at least maprendering.c, mapcairo.c and mapgeomutil.cpp are affected by one of more of those issues. It would be ideal to fix them ASAP before the 6.0 release so that eventual patches will be easier to port in the future between 6.0 and 6.x releases.

1- The standard MapServer header is missing in some of them.

2- The files use a mix of TABs and spaces for indent. The convention in MapServer source is that all tabs should be converted to the right amount of spaces so that indent is right in any editor, no matter what the tab size setting is in the editor. (Most editors have a setting to automatically convert tabs to spaces to help avoiding this problem in the future)

Note that emacs has macros to facilitate the fix of those issues, so most of the work after applying them should be reviewing the results for correctness. If you are not setup to do this easily then please let me know and I'll try to do it before next beta.

Change History (2)

comment:1 by dmorissette, 13 years ago

Cc: tbonfort added
Owner: changed from tbonfort to dmorissette

I'll take care of this since Thomas is away

comment:2 by dmorissette, 13 years ago

Resolution: fixed
Status: newclosed

Fixed in r11504.

Thomas: you may want to review the "Purpose" line in the header of each file and put something better than what I did.

Note: See TracTickets for help on using tickets.