Ticket #3820 (closed defect: fixed)
mapkml*.* code review - coding style fixes required
|Reported by:||dmorissette||Owned by:||assefa|
On a quick code review, I noticed the following coding style issues in the mapkml*.cpp/.h files. It would be ideal to fix them ASAP before the 6.0 release so that eventual patches will be easier to port in the future between 6.0 and 6.x releases.
1- The files use a mix of TABs and spaces for indent. The convention in MapServer source is that all tabs should be converted to the right amount of spaces so that indent is right in any editor, no matter what the tab size setting is in the editor. (Most editors have a setting to automatically convert tabs to spaces to help avoiding this problem in the future)
2- The files are stored in DOS CR/LF format in the SVN repository. This is not mandatory, but while we're at it we could run dos2unix on them and commit new versions without the CR/LF
Note that emacs has macros to facilitate the fix of those issues, so most of the work after applying them should be reviewing the results for correctness. If you are not setup to do this easily then please let me know and I'll try to do it before next beta.