mapogl*.cpp code review - minor fixes required

[dmorissette]

After a quick review of the OpenGL source files (mapogl*.cpp/.h), here are a few aesthetic issues that we should fix. It would be ideal to do this ASAP before the 6.0 release so that eventual patches will be easier to port in the future between 6.0 and 6.x releases.

1- Please include the standard mapserver header at the top of every source file. See mapserver.h or other .c files for an example.

2- The files use TABs, and from a quick check it would seem that they are intended to be 4 chars tabs. The convention in MapServer source is that all tabs should be converted to the right amount of spaces so that indent is right in any editor, no matter what the tab size setting is in the editor. (Most editors have a setting to automatically convert tabs to spaces to help avoiding this problem in the future)

3- The files mapoglrenderer.cpp/.h contain stray CR's (^M's), presumably because they were created on Windows with DOS CR/LF, and then copied to a Linux box and committed to SVN from the Linux box. It is not mandatory, but would be cleaner, to run dos2unix on them and commit new versions without the CR/LF

[dmorissette]

Note that emacs has macros to facilitate the fix of those issues, so most of the work after applying them should be reviewing the results for correctness. If you are not setup to do this easily then please let me know and I'll try to do it before next beta.

[dmorissette]

Did a svn propset that seems to have solved the DOS CR/LF issue. (r11502, r11503).

svn propset svn:eol-style native *.h *.c *.cpp

[toby]

I have made a commit to solve issues 1 and 2. r11512