Opened 13 years ago

Closed 13 years ago

#3779 closed defect (fixed)

WCS implementation should not lookup wms_* metadata

Reported by: dmorissette Owned by: sdlime
Priority: normal Milestone: 6.0 release
Component: WCS Server Version: unspecified
Severity: normal Keywords:
Cc: assefa, warmerdam, sdlime, schpidi

Description

I notice that the current implementation of WCS in mapwcs.c and mapwcs20.c calls msOWSLookupMetadata() with the "COM" namespaces, which means that it will lookup its metadata using the prefixes "wcs_*", then "ows_*", and then "wms_*".

We should not use "wms_*" for a WCS service since this prefix is for WMS-specific metadata, and if we intend to have metadata values shared between multiple services then it is "ows_*" that should be used.

Attachments (1)

com_co.diff (51.8 KB ) - added by schpidi 13 years ago.

Download all attachments as: .zip

Change History (6)

by schpidi, 13 years ago

Attachment: com_co.diff added

comment:1 by schpidi, 13 years ago

I agree that we shouldn't use "wms_*" metadata in a WCS to avoid confusion.

I've changed all "COM" occurrences to "CO" (see attached file) and successfully ran all wxs/wcs_* tests in msautotest.

Should I commit the changes?

comment:2 by dmorissette, 13 years ago

I'd say go ahead and commit, unless Steve or Frank are aware of reasons why things were done this way in the beginning. (Maybe wait a day to leave them a chance to comment)

comment:3 by warmerdam, 13 years ago

I imagine it was just done as a convenience. If the change is applied, which is ok with me, please ensure to update the MIGRATION guide appropriately as all of a sudden some peoples WCS services will stop working properly.

comment:4 by sdlime, 13 years ago

Yup, convenience... WMS came first and we wanted to leverage all the metadata folks had put in place already- probably pre-ows_*. I'm ok with forcing folks to make explicit decisions.

Steve

comment:5 by schpidi, 13 years ago

Resolution: fixed
Status: newclosed

Commited in r11349.

Note: See TracTickets for help on using tickets.