Opened 13 years ago

Last modified 13 years ago

#3629 new defect

Missing MS_ABS for x axis in extent calcs - mapwms.c

Reported by: each2 Owned by: mapserverbugs
Priority: normal Milestone:
Component: WMS Server Version: 5.6
Severity: normal Keywords: mapwms.c, WMS extents
Cc:

Description

FC12 x64, 5.6.5 the extent calcs for an "adjust_extent" (line 1160) appear to be NOT getting the absolute value for the x axis, but appear to doing so for the y axis on the next few lines.

dx = (map->extent.maxx - map->extent.minx) / map->width;

This is inconsistent behaviour with other cases in the same code, e.g. line 955 (!nonsquare_enabled)

Wouldn't we expect it to be using MS_ABS like this?

dx = MS_ABS(map->extent.maxx - map->extent.minx) / map->width;

Additional note: in 5.4.2 neither x nor y are using MS_ABS.

Change History (1)

comment:1 by sdlime, 13 years ago

Component: MapServer C LibraryWMS Server
Owner: changed from sdlime to mapserverbugs
Note: See TracTickets for help on using tickets.