Reprojection Error with Filter Geometry not reported

[warmerdam]

In the msautotest/wxs/wms_sld.map file, the test wms_get_map_multi_polygon_filter.png is currently failing for me. No features are drawn. A blank map is produced.

Stepping through the code it appears to be due to a failure to initialize the epsg:42304 projection. I can deal with this, but what is less clear is why the error was not reported despite an msSetError() call being made low in the guts.

[warmerdam]

The problem seems to be this code in mapogcfilter.c which does not make any further attempt to report problems if FLTParseEpsgString() fails.

        /*reproject shape if epsg was set*/
        if (psNode->pszSRS &&  map->projection.numargs > 0 &&
            FTLParseEpsgString(psNode->pszSRS, &sProjTmp))
           msProjectShape(&sProjTmp, &map->projection, psQueryShape);

I'll see if I can come up with a patch.

[warmerdam]

I have applied a fairly specific fix for my problem in trunk (r10373) and now the error is properly returned as an exception. I also extended similar changes to a few other places in trunk without actual testing (r10374).

Assefa, could you review? I'm not inclined to backport these since there is substantial risk of breakage, and the primary benefit is just easier debugging of broken configurations.

This SLD/filter code is complicated!