Opened 14 years ago

Last modified 14 years ago

#3430 new defect

OFC Filters sql should be enclosed by parentheses

Reported by: assefa Owned by: assefa
Priority: normal Milestone: 5.6.4 release
Component: WFS Server Version: unspecified
Severity: normal Keywords: ogc filter oracle spatial
Cc:

Description

When generating OGC filters, make sure to enclose it with parentheses. This will avoid problems for example when using with Oracle. test url used: ​http://127.0.0.1/cgi-bin/mapserv.exe?map=f:/projects/mapserver-buildkit-2008/mapserver/msautotest/wxs/wfs_filter_mine.map&&SERVICE=WFS&VERSION=1.0.0&REQUEST=GetFeature&TYPENAME=popplace_oracle&FILTER=%3CFilter%3E%3COr%3E%3CPropertyIsEqualTo%3E%3CPropertyName%3EOGR_FID%3C/PropertyName%3E%3CLiteral%3E22%3C/Literal%3E%3C/PropertyIsEqualTo%3E%3CPropertyIsEqualTo%3E%3CPropertyName%3EOGR_FID%3C/PropertyName%3E%3CLiteral%3E14%3C/Literal%3E%3C/PropertyIsEqualTo%3E%3CPropertyIsEqualTo%3E%3CPropertyName%3EOGR_FID%3C/PropertyName%3E%3CLiteral%3E11%3C/Literal%3E%3C/PropertyIsEqualTo%3E%3CPropertyIsEqualTo%3E%3CPropertyName%3EOGR_FID%3C/PropertyName%3E%3CLiteral%3E13%3C/Literal%3E%3C/PropertyIsEqualTo%3E%3C/Or%3E%3C/Filter%3E&aaa=1

Attachments (1)

bug3430.zip​ (1.3 KB ) - added by assefa 14 years ago.
patch against 5.4 and 5.2 branchs

Download all attachments as: .zip

Change History (3)

comment:1 by assefa, 14 years ago

fixed in 5.6 branch r10102

Note that this was already fixed in trunk as part of work done bore bugs #2720 and #2840

I will attach a patch against 5.4.x branch

by assefa, 14 years ago

Attachment: bug3430.zip​ added

patch against 5.4 and 5.2 branchs

comment:2 by assefa, 14 years ago

patch against 5.4 was tested.

patch against 5.2 was not tested but is similar to 5.4.

Note: See TracTickets for help on using tickets.