Ticket #331 (assigned defect)

Opened 5 years ago

Last modified 2 months ago

[OGR] Use layerinfo in layerObj

Reported by: dmorissette Assigned to: dmorissette (accepted)
Priority: high Milestone: 5.4 release
Component: OGR Support Version: 4.0
Severity: normal Keywords:
Cc:

Description (Last modified by dmorissette)

Need to convert the OGR and WFS layer types to use the generic lp->layerinfo 
instead of custom handles.  Important note: be careful about WFS since it's a 
wrapper around OGR...

Steve Lime wrote:
> 
> Dan: I've taken care of this for everything but the 2 you mention. I'll
> be hidding the shpfile structs behind the layerinfo pointer too.
> 
> Steve
> 
> >>> Daniel Morissette <morissette@dmsolutions.ca> 02/17/03 16:46 PM >>>
> Steve Lime wrote:
> >
> > Dan: I'm poking around the code a bunch trying to wrap stuff up.
> Anyway,
> > one thing I noticed is the variety of layerinfo pointers in the layer
> > object, one for each connection type. For simplicity wouldn't it be
> just
> > as easy to specify a single (eg. void *layerinfo;) pointer? We already
> > do that for iteminfo.
> >
> 
> I agree that this would be a nice change, but there may be an issue with
> merging the WFS and OGR layers since the WFS layer uses an OGR
> connection, so both the wfslayerinfo and the ogrlayerinfo are used at
> the same time.  You could leave the WFS and OGR there untouched and let
> me know when your other changes are done and I'll take care of fixing
> them myself by creating a combined data structure for WFS and OGR.
>

Change History

05/17/06 15:13:58 changed by dmorissette

  • status changed from new to assigned.
  • milestone set to 4.10 (5.0?) release.
Checking this now.

05/19/06 17:16:14 changed by dmorissette

I have done a first pass (in 4.9 CVS) to remove the ogrlayerinfo and use
layerinfo instead. Tested and working fine with both ogr and wfs connections.

We still need to do something about the wfslayerinfo member, but since WFS
connections use an OGR connection to read the GML this will be a little more tricky.

09/05/06 08:01:52 changed by dmorissette

  • milestone changed from 4.10 release to 5.0 release.
Moving target milestone to 5.0 release.

07/27/07 16:32:49 changed by dmorissette

  • description changed.
  • milestone changed from 5.0 release to 5.2 release.

06/18/08 13:01:45 changed by dmorissette

  • milestone changed from 5.2 release to 5.4 release.