libgd < 2.0.30 compatibility (patch included)

[dpanech]

The file mapagg.cpp uses the function "gdImageGetTrueColorPixel", which is missing in libgd 2.0.28 that I'm using. The attached patch fixes the issue.

See also: ​http://n2.nabble.com/MS-5-0-0-rc2-issue-tt1999432.html#a1999433

[dpanech]

It seems this website is unable to display unified diffs properly. Please download the file to see all changes.

[dmorissette]

Reassigned to Alan to review and apply the patch if appropriate.

(BTW, multi-file diffs normally work with this Trac instance. There must be something odd or missing in your patch files that confuses it.)

[dpanech]

Replying to dmorissette:

Reassigned to Alan to review and apply the patch if appropriate.

(BTW, multi-file diffs normally work with this Trac instance. There must be something odd or missing in your patch files that confuses it.)

There are 2 files in the diff, it only shows the first one. Patch generated with GNU diff ("diff -u oldfile newfile"). The "patch" program works correctly with this patch. What am I doing wrong?

[dmorissette]

My guess is that your patches are missing the multi-file header/separator that 'svn diff' would produce:

Index: path/to/file.c
===================================================================

Since Trac/diff issues are off-topic for this ticket, let's continue the discussion on the mapserver-dev list if necessary.

[dpanech]

Updated patch with "Index: ..." lines

[aboudreault]

The patch doesn't seem to work when we specify the path where gd is installed. AC_CHECK_DECL seems to only look in the default include paths.

[aboudreault]

I've added a small hack with the CFLAGS/CXXFLAGS to fix the problem reported in the last comment. Thanks for the patch dpanech.

Fixed and committed in r10016.