Postgresql 7.x compatibility (patch included)

[dpanech]

The file mappostgis.c uses the function PQserverVersion, which was is absent in libpq 7.4.19 that I am using.

I think "select version();" SQL should do the same thing.

[dpanech]

Note about the patch: it changes two files, configure.in and mappostgis.c. But the "Preview" mode on this website only shows the first file. Download the patch to see al changes, please.

[dpanech]

Patch for finding out server version using SQL when PQserverVersion function is unavailable

[dmorissette]

Moving to postgis component for Paul to review.

[pramsey]

The patch is incomplete, it only has the configure routine for setting the define. BTW, this must be against a very old version of PostGIS as well... what PostGIS version are you running?

[pramsey]

dmorissette has set me straight, the patch is complete but not displaying right. This line seems suspect to me:

    int pgversion = atoi (PQgetvalue (pgresult, 0, 0));

When I run select version(); I get a big string:

PostgreSQL 8.4.2 on i386-apple-darwin10.2.0, compiled by GCC i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5646) (dot 1), 64-bit

Are you saying on earlier versions you get the simple version number string? 70400?

[pramsey]

Altered patch

[pramsey]

Please test this version of the patch and see if it does what you want/expect.

[dpanech]

Thanks, your patch works; but I found a somewhat better/safer way of getting the version string. See 3291-2.patch.

[dpanech]

Use PQparameterStatus to get version string

[dpanech]

PQparameterStatus ("server_version") returns just the version string ("7.4.19" or some such), so we can avoid executing SQL.

[dpanech]

Replying to pramsey:

The patch is incomplete, it only has the configure routine for setting the define. BTW, this must be against a very old version of PostGIS as well... what PostGIS version are you running?

I'm running version 7.4.19... but anyway, it was my mistake, "version()" does return a long "human-readable" string. See corrections in my second patch.

[pramsey]

Changes committed against branch 5.4, 5.6 and trunk.