OGRFileOpen - double free of the datasource in case of failure

[aboudreault]

In the function OGRFileOpen, once the connection to the file/db has been established, the connection is registered in the pool. Then we try to get the to get the layer or execute the sql. If the ExecuteSQL/GetLayer fail, a call to OGR_DS_Destroy is done: but the connection is already registered in the pool and this results in a seg fault when trying to destroy (again) the datasource when msConnPoolClose is called.

[aboudreault]

FrankW, I suggest to remove those calls in mapogr.c and let the connection pooling handle the connection close. Do you see any problem with that ?

[warmerdam]

Alan,

I agree, I think removing the OGR_DS_Destroy() call in the error exit would be appropriate, and likely replacing it with a call to release the pool connection.

[aboudreault]

Fixed and committed in r9687.