WFS hits count is incorrect if the request conatin 2 layers or more

[assefa]

WFS hits count is incorrect if the request conatin 2 layers or more: return only the hits for the first layer. This is a safe change.

--- mapwfs.c (revision 9571) +++ mapwfs.c (working copy) @@ -1680,7 +1680,6 @@

if (GET_LAYER(map, j)->resultcache && GET_LAYER(map, j)->resultcache->numresults > 0) {

iNumberOfFeatures += GET_LAYER(map, j)->resultcache->numresults;

• break;

}

}

[assefa]

should I wait for the release or just commit the change which is strait forward? I really would not want anything to hold up tomorrow's final release.

[dmorissette]

Is this new to 5.6? If this has been around for several releases then I'd say wait for 5.6.1, otherwise if that's new to 5.6 and you are confident that this is the right fix then please go ahead now.

Is it clearly stated somewhere in the spec whether the count is per layer/typename or global?

[assefa]

This was part of #2907 and was new to 5.6. The count if for the whole GetFeature request, so for all results. committed in r9572.

Thanks

[assefa]

note that the previous commit was incomplete. Added missing test in r9573.