Changes between Initial Version and Version 1 of Ticket #3065


Ignore:
Timestamp:
Jul 7, 2009, 12:23:37 PM (15 years ago)
Author:
dmorissette
Comment:

Assigned to Alan to look into this.

Assefa, Jeff: MS4W 3.0-beta seems to be using a RC of PHP 5.3. Did you not encounter those issues?

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3065

    • Property Cc dmorissette assefa jmckenna added
    • Property Owner changed from mapserverbugs to aboudreault
    • Property Milestone → 5.4.2 release

  • Ticket #3065 – Description

    initial v1  
    22
    33Hardcoding that condition to true, mapscript/php3/php_regex.c failed to compile since its
     4{{{
    45#include "regex/regex_extra.h"
    56#include "regex/regex.h"
     7}}}
    68files didn't exist.  After commenting those out and adding
     9{{{
    710#include "ext/ereg/regex/regex.h"
     11}}}
    812things compiled, but apache processes would die with glibc free() errors.  In mapscript/php3/php_regex.c, by commenting out the call to regexec() in ms_regexec() (hardcoding return -1), and the calls to regfree() and free() in ms_regfree(), processes no longer segfault.
    913
    … …  
    1115
    1216I'm not sure if this matters, but I also changed API_EXPORT #define stuff in mapregex.h to better match that in php's php/ext/ereg/regex/regex.h, which includes an extra clause for
     17{{{
    1318#elif defined(__GNUC__) && __GNUC__ >= 4
    1419#define API_EXPORT(type)    __attribute__ ((visibility("default"))) type
     20}}}