Issue using msdrawQueryLayer for GEOMTRANSFORM (patch for mapdraw.c)

[djay]

When I used line layer using the new GEOMTRANSFORM option I saw that when querying I get strange result drawed as presented ​here. As you could see the style which use the GEOMTRANSFORM option (end and start in this case) was not take in account. So I've red the mapdraw.c file to see that only the last style was hilighted (if needed) and as the geomtransform was not take in account then the symbol was displayed all along the line (as shown in the outputed image before).

One solution to get at least the line highlighted I only have to put the first style at the end, but I ws still unable to highlight the transformed geometry which didn't seems to be a solution from my point of view.

So, I've made a small patch to be able to first highlight not only one style for a layer but all styles and to display the transformed geometry properly. This way I've solved the issue when querying a line layer but now I have to take care about the querying of point layers.

Hope to be able to provide a beter patch soon to be able to use this color scheme for all styles only in the case of a line layer.

Hope I didn't do something wrong.

[djay]

The quoted patch

[tbonfort]

steve, could you comment please:

in querymode, we only highlight the topmost style, and don't touch the others. In the case of GEOMTRANSFORM, that is usually not what we want to obtain, as e.g. for an GEOMTRANSFORM END you also want the line itself to highlight, not only the arrowhead.

two possible solutions:

• add someway for the user to indicate which styles should be highlighted
• always highlight styles with geomtransform set.

also, should this be pushed off to post 6.0? (I don't think we risk breaking backwards compatibility with the second approach, as the current usage is probably unsable/unused)

[sdlime]

This isn't a new issue and there aren't many folks complaining so I think I'd push things off until 6.2. Djay can apply the patch locally I guess until then. We might want to consider your first idea as a more suitable fix. I think without explicit settings the rules may get hopelessly complex. I mean, even for a simple case, selecting a hollow road I could see benefits to highlighting the inside, outside or even both.

Steve