Opened 15 years ago

Last modified 15 years ago

#2991 assigned defect

Issue saving mapfile using autoangle option in style

Reported by: djay Owned by: sdlime
Priority: normal Milestone: 5.6 release
Component: MapServer C Library Version: 5.4
Severity: normal Keywords:
Cc:

Description

I've tried to use mapserver 5.4.0 and then I saw that when trying to save a mapfile containing a style using autoangle option, it was replaced by a 360° angle.

So, I've made small fixes in mapfile.c which solves this "issue" when saving layers using an auto angle and won't add a 360° angle by default for a saved layer anymore (using a default zero valued angle rather than 360 previous default value).

Hope I didn't do something wrong.

Attachments (3)

mapserver.patch (1.2 KB ) - added by djay 15 years ago.
The quoted patch
mapserver.2.patch (1.2 KB ) - added by djay 15 years ago.
The quoted patch
mapfile-5.4.0.patch (1.1 KB ) - added by djay 15 years ago.
The new patch to solve saving mapfile using autoangle option

Download all attachments as: .zip

Change History (6)

by djay, 15 years ago

Attachment: mapserver.patch added

The quoted patch

by djay, 15 years ago

Attachment: mapserver.2.patch added

The quoted patch

comment:1 by djay, 15 years ago

Except sending the patch twice :)

comment:2 by sdlime, 15 years ago

Milestone: 5.4.1 release
Status: newassigned

Changing the default probably isn't the way to go. Certain circle drawing for points would break. I think the better fix is to change the code in the style writer to check the angle against 360 instead of 0. Can you try that?

Steve

comment:3 by djay, 15 years ago

Thank you for your answer.

You've right using the 360 degree solve this issue also and be safer for drawing point (I didn't check for this).

I will provide here the new patch for the mapfile.c file.

by djay, 15 years ago

Attachment: mapfile-5.4.0.patch added

The new patch to solve saving mapfile using autoangle option

Note: See TracTickets for help on using tickets.