Opened 15 years ago

Closed 15 years ago

#2865 closed enhancement (fixed)

RFC 49 implementation

Reported by: tbonfort Owned by: tbonfort
Priority: normal Milestone: 5.4 release
Component: MapServer C Library Version: svn-trunk (development)
Severity: normal Keywords: rfc49, symbology
Cc: tamas

Description

ticket to track changes with regards to rfc 49:

http://mapserver.org/development/rfc/ms-rfc-49.html

Attachments (1)

maplabel.patch (666 bytes ) - added by szigeti 15 years ago.
trivial patch

Download all attachments as: .zip

Change History (10)

comment:1 by tbonfort, 15 years ago

commited in r8453

comment:2 by szigeti, 15 years ago

objection! The proposed solution in r8453 ignores the case when (label==NULL)

 Segmentation fault.
0x08065df8 in msAddLabel (map=0x816ae48, layerindex=6, classindex=0, 
    shapeindex=-1, tileindex=-1, point=0xbfd4b2e0, labelpath=0x0, 
    string=0x8145b92 " ", featuresize=1, label=0x0) at maplabel.c:322
322	    if((label->maxscaledenom != -1) && (map->scaledenom >= label->maxscaledenom))

by szigeti, 15 years ago

Attachment: maplabel.patch added

trivial patch

comment:3 by tbonfort, 15 years ago

can you confirm that this was triggered either with an embedded legend or scalebar, or by using the mapscript drawpoint function.

if so, I would suspect r8483 fixes the segfault

comment:4 by szigeti, 15 years ago

it was within an embedded scalebar:

(gdb) bt
#0  0x08067398 in msAddLabel ()
#1  0x080fd90c in msEmbedScalebar ()
#2  0x0807c41c in msDrawMap ()
#3  0x080502cd in main ()

comment:5 by tamas, 15 years ago

Also fixed segfault in r8492 when classObj.numstyles = 0

comment:6 by tamas, 15 years ago

Cc: tamas added

comment:7 by tbonfort, 15 years ago

documentation updated

comment:8 by aalbarello, 15 years ago

mapcopy.c lacks the required lines needed to copy these settings at style and label level, that is

    MS_COPYSTELEM(minscaledenom);
    MS_COPYSTELEM(maxscaledenom);

is missing from msCopyLabel and

    MS_COPYSTELEM(outlinewidth);
    MS_COPYSTELEM(minscaledenom);
    MS_COPYSTELEM(maxscaledenom);

is missing from msCopyStyle.

Regards,

Andreas

comment:9 by tbonfort, 15 years ago

Resolution: fixed
Status: newclosed

also missing label align and maxlength

fixed in r9395

Note: See TracTickets for help on using tickets.