mode=map parameter causes WMS requests to give an error

[agxs]

If a GetCapabilities request is sent such as:

​http://<hostname>/mapserv?map=<mapfile>&mode=map&REQUEST=GetCapabilities&service=WMS&version=1.1.1

The following error is returned in 5.2:

mapserv() : Web application error. SERVICE=WMS requested, but that OGC web service is not enabled in this build. Please rebuild MapServer with appropriate options.

This error is not returned in versions previous to 5.2

When the parameter mode=map is removed then the request works correctly.

Ticket created upon request by Daniel Morissette on #mapserver on freenode.

[dmorissette]

This is probably a side-effect of the work started in ticket #2531 to add mode=ows. We need to fix this to return a more meaningful error message.

[dmorissette]

There were redundant tests in mapserv.c checking if service was passed but not caught by msOWSDispatch() and producing this error message if mode != ows was passed.

I have removed the tests since each msXXXDispatch function already reports its own error already of that service is not compiled in.

Done in SVN trunk r7876.

Still need to backport and retest in 5.2.x branch (tomorrow).

[dmorissette]

Backported to branch-5-2 in r7877.

Fixed.