Ticket #2720 (closed defect: fixed)
Filter encoding: simple filters using propertyislike not applied properly
| Reported by: | assefa | Owned by: | assefa |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.0 release |
| Component: | WFS Server | Version: | unspecified |
| Severity: | normal | Keywords: | |
| Cc: | bartvde@… |
Description
This was reported by Bart,
"I am tracking down why a simple PropertyIsLike? filter is not being sent to the database.
The reason is that in FLTValidForPropertyIsLikeFilter there is a check on the psLeftNode and psRightNode being null. Ofcourse this is not the case, since the leftNode contains the propertyname and the rightnode contains the value. So the function returns false.
if (psFilterNode->psLeftNode == NULL && psFilterNode->psRightNode == NULL)
return 1;
return 0;
This code was not in 5.0.0, do you know why this was introduced?"
response from Assefa:
But obviously the function is incorrect. The previous code (5.0) should work but is limited. Here is what the intention is:
- if it is a MapServer flat file layer
- for thr filter encoding to be considered 'simple" : only one propertyislike is permitted if we want to use the filter/filteritem parameters of the layer. The code in 5.0 works for that
- if it is a DB layer: we can have unlimited number of propertyislike filters since the final expression is would end up being something like: (attribute_name like 'value')
Revering back to the 5.0 code would be a start but I need to check for the layer type to make sure that both cases described are supported properly.
Attachments
-
bug2720.zip
(5.0 KB) - added by assefa
3 years ago.
-
mapserver-5.6.1-2720-free_crash.patch
(1.2 KB) - added by dionw
3 years ago.
- Patch to fix trimming of pszFinalAttributeValue string
