Opened 16 years ago

Closed 16 years ago

#2712 closed defect (fixed)

[SLD WMS] Intersects filter with geometry in different projection than map does not work

Reported by: bartvde Owned by: assefa
Priority: normal Milestone: 5.2.1 release
Component: WMS Server Version: unspecified
Severity: normal Keywords:
Cc:

Description

The geometry needs to be reprojected, just like this is done for a BBOX filter (see also ticket:2079).

I'll attach a patch which fixes this.

Attachments (2)

ms_reprojection_bug.patch (2.7 KB ) - added by bartvde 16 years ago.
bug_2712.patch (8.4 KB ) - added by assefa 16 years ago.

Download all attachments as: .zip

Change History (10)

by bartvde, 16 years ago

Attachment: ms_reprojection_bug.patch added

comment:1 by assefa, 16 years ago

Owner: changed from mapserverbugs to assefa
Status: newassigned

comment:2 by assefa, 16 years ago

Status: assignednew

Bart,

Patch seems to be incomplete. I think you forgot to attach patch for mapogcfilter.c.

comment:3 by bartvde, 16 years ago

Hi Assefa, the trac view only displays the first part somehow, but if you download it in the original format you'll get the full patch.

comment:4 by assefa, 16 years ago

Status: newassigned

Bart,

I reworked the patch a bit and attached is a version that works for me. Can you please give it a try and let me know. Thanks.

by assefa, 16 years ago

Attachment: bug_2712.patch added

comment:5 by bartvde, 16 years ago

I am getting internal server errors when applying this patch, will need to investigate. Also the part for mapserver.h is missing or not? I am applying both this and the patch to 2079.

comment:6 by assefa, 16 years ago

yes I forgot the patch in mapserver.h:

--- mapserver.h (revision 7830) +++ mapserver.h (working copy) @@ -381,7 +381,7 @@

FilterNodeType eType; char *pszValue; void *pOther;

- + char *pszSRS;

struct _FilterNode *psLeftNode; struct _FilterNode *psRightNode;

} FilterEncodingNode;

I will build this in a non debug environment to see if I get the crash. My test case is based on map/data contained in msautotest. I will report after.

comment:7 by bartvde, 16 years ago

This part was also missing:

  function FilterEncodingNode *FLTCreateFilterEncodingNode(void)
    .....
    psFilterNode->pOther = NULL;
     psFilterNode->pszSRS = NULL;
   ....

comment:8 by assefa, 16 years ago

Resolution: fixed
Status: assignedclosed

Committed:

5.2.x branch: r7831 main trunk: r7832

Note: See TracTickets for help on using tickets.