Opened 16 years ago

Closed 13 years ago

#2659 closed defect (fixed)

symbol with (x -99) offset causes wrong rendering

Reported by: diletant Owned by: tbonfort
Priority: normal Milestone: 6.0 release
Component: AGG Version:
Severity: normal Keywords: offset symbol agg render
Cc: cnieman

Description

inside a map file, if you assign an offset (type x -99) on several symbols from a same class, some non-existing pattern are graphically rendered. For instance, it seems that linear segments are prolonged further than their real end.

This issue doesn't appear if only one offset (x -99) symbol is drawn for a class item.

Attachments (6)

snapshot_ms52.bmp (187.8 KB ) - added by diletant 16 years ago.
snapshot_ms52_closeup.bmp (77.8 KB ) - added by diletant 16 years ago.
snapshot_ms52_2.PNG (26.8 KB ) - added by diletant 16 years ago.
original linear segments (green), with offset (red), one of them is drawn straightly towards heading north (upper right side of the picture)
bug.map (1.8 KB ) - added by diletant 16 years ago.
data.rar (66.4 KB ) - added by diletant 16 years ago.
snapshot_ms52_3.bmp (167.5 KB ) - added by diletant 16 years ago.

Download all attachments as: .zip

Change History (19)

by diletant, 16 years ago

Attachment: snapshot_ms52.bmp added

comment:1 by diletant, 16 years ago

And the wrongly rendered's lines are changing with scale (bbox related)

by diletant, 16 years ago

Attachment: snapshot_ms52_closeup.bmp added

in reply to:  description ; comment:2 by diletant, 16 years ago

Keywords: offset symbol agg render added
Summary: multiple symbol with (x -99) offset cause wrong renderingsymbol with (x -99) offset causes wrong rendering

Replying to diletant:

inside a map file, if you assign an offset (type x -99) on a symbol, some non-existing patterns are graphically rendered. For instance, it seems that linear segments are prolonged further than their real end.

in reply to:  2 ; comment:3 by tbonfort, 16 years ago

Replying to diletant:

Replying to diletant:

inside a map file, if you assign an offset (type x -99) on a symbol, some non-existing patterns are graphically rendered. For instance, it seems that linear segments are prolonged further than their real end.

hi, could you come up with a limited test case (data+mapfile) that exhibits this, as I can't reproduce this with what I have. Also, does this happen when using the GD renderer ?

in reply to:  3 comment:4 by diletant, 16 years ago

Replying to tbonfort:

Replying to diletant:

Replying to diletant:

inside a map file, if you assign an offset (type x -99) on a symbol, some non-existing patterns are graphically rendered. For instance, it seems that linear segments are prolonged further than their real end.

hi, could you come up with a limited test case (data+mapfile) that exhibits this, as I can't reproduce this with what I have. Also, does this happen when using the GD renderer ?

Ok done (see attached files) It's specific to AGG + offset (no problem encountered with AGG/no_offset or GD/with_offset)

by diletant, 16 years ago

Attachment: snapshot_ms52_2.PNG added

original linear segments (green), with offset (red), one of them is drawn straightly towards heading north (upper right side of the picture)

comment:5 by diletant, 16 years ago

request : MAP=/ms4w/apps/gmap/htdocs/bug.map&SERVICE=WMS&REQUEST=GetMap&VERSION=1.3.0&LAYERS=layer_1&STYLES=&FORMAT=image/png&BGCOLOR=0xFFFFFF&TRANSPARENT=True&SRS=EPSG:4326&BBOX=2.373046875,48.86471476180277,2.4169921875,48.893615361480194&WIDTH=256&HEIGHT=256

comment:6 by tbonfort, 16 years ago

Resolution: fixed
Status: newclosed

fixed in r7758

the bug happened when the first segment of a polyline was horizontal

thanks for the bugreport and testcase

comment:7 by diletant, 16 years ago

Resolution: fixed
Status: closedreopened

by diletant, 16 years ago

Attachment: bug.map added

by diletant, 16 years ago

Attachment: data.rar added

by diletant, 16 years ago

Attachment: snapshot_ms52_3.bmp added

comment:8 by tbonfort, 16 years ago

Resolution: fixed
Status: reopenedclosed

the bug was due to some leftover integer rounding from the original gd-only code.

  • fixed in trunk in r7958
  • fixed in 5.2 branch in r7959

diletant: I'm crossing my fingers this will be the final fix for your issues. Your shapefile is such a mess it's a perfect testcase for bringing up rounding issues :)

comment:9 by tbonfort, 16 years ago

Resolution: fixed
Status: closedreopened

there are still some leftover cases where the rendering is incorrect, reopening

comment:10 by diletant, 15 years ago

may be a useful tip :

This issue is still active in 5.2.1 release. the wrong leftover cases might appear or disappear only by changing the size of the image or the bounding box.

Thanks & good luck !

comment:11 by cnieman, 15 years ago

Cc: cnieman added

comment:12 by tbonfort, 15 years ago

Milestone: 5.6 release6.0 release

comment:13 by tbonfort, 13 years ago

Resolution: fixed
Status: reopenedclosed

I couldn't reproduce the defects in 5.4, 5.6 and 6.0, so I'm closing this.

reopen with an updated test-case if this is still ocurring.

thanks for the test-cases!

Note: See TracTickets for help on using tickets.