Ticket #2615 (closed defect: fixed)

Opened 2 months ago

Last modified 2 months ago

Call curl_global_init() only when really required

Reported by: dmorissette Assigned to: dmorissette
Priority: normal Milestone: 5.2 release
Component: WMS Client Version: unspecified
Severity: normal Keywords:
Cc: pramsey

Description

Paul Ramsey found and reported the following performance issue on the --dev list:

Another thing Shark tells me is that we are burning resources in curl_global_init (called from msHTTPInit via msHTTPInitRequestObj) even when there are no WMS or WFS layers defined. This is eating about 5% of the total cycles, on a fairly well-tuned map file, and could be fixed.

Change History

05/12/08 15:30:09 changed by dmorissette

  • status changed from new to assigned.

05/12/08 15:44:46 changed by dmorissette

The fix for this is trivial: move the msHTTPInit() call from msHTTPInitRequestObj() to msHTTPExecuteRequests() since that's the only place where curl calls are made.

I've made that change in r7582.

There is also room for another optimization in msDrawMap() (mapdraw.c) where we should call msHTTPInitRequestObj() only *if* there are WMS/WFS layers to draw. Checking that now.

05/12/08 16:03:58 changed by pramsey

Optimization two is probably not worth your time. The init stuff has disappeared from the trace of noticeable function calls now that you've moved the curl init.

05/12/08 16:36:35 changed by dmorissette

  • status changed from assigned to closed.
  • resolution set to fixed.

Too late, I was already almost done rearranging things in msDrawMap() when I read your comment, and it really bugged me to see an allocation of numLayers * HTTPRequestObjs all the time even when there are no WMS/WFS layers to download, which is 99% of the time.

Committed to trunk in r7583.

Fixed.