A GetCapabilities request to a WCS 1.0.0 server without the version parameter should not return an exception

[nsavard]

When the version parameter is not specify in a GetCapabilities request to a WCS 1.0.0 server, then the server should return the response with the highest version supported. Actually the following service exception report is returned.

<?xml version='1.0' encoding="ISO-8859-1" standalone="no" ?> <!DOCTYPE ServiceExceptionReport SYSTEM "​http://schemas.opengis.net//wms/1.1.1/exception_1_1_1.dtd"> <ServiceExceptionReport version="1.1.1"> <ServiceException> msOWSParseVersionString(): WMS server error. Invalid version (). OWS version must be in the format &#39;x.y&#39; or &#39;x.y.z&#39; </ServiceException> </ServiceExceptionReport>

[nsavard]

I forgot to paste the request. Here it is:

​http://dev1.lan.mapgears.com/manwe/cgi-bin/mswcs100_ogc_cite?ReQuEsT=GetCapabilities&VeRsIoN=&SeRvIcE=WCS

[nsavard]

Also the following request must return a response with the highest version supported:

​http://dev1.lan.mapgears.com/manwe/cgi-bin/mswcs100_ogc_cite?ReQuEsT=GetCapabilities&VeRsIoN=1.0.2&SeRvIcE=WCS

but it returns the following exception:

<?xml version='1.0' encoding="ISO-8859-1" ?> <ServiceExceptionReport version="1.2.0" xmlns="​http://www.opengis.net/ogc" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/ogc ​http://schemas.opengis.net//wms/1.1.1/OGC-exception.xsd">

<ServiceException code="InvalidParameterValue" locator="version">msWCSDispatch(): WCS server error. WCS Server does not support VERSION 1.0.2. </ServiceException>

</ServiceExceptionReport>

[nsavard]

And when a request is sent with a lower version number than the one supported, a response with the lowest known version must be returned but now the following resquest:

​http://dev1.lan.mapgears.com/manwe/cgi-bin/mswcs100_ogc_cite?ReQuEsT=GetCapabilities&VeRsIoN=0.8.0&SeRvIcE=WCS

returns the following exception:

<?xml version='1.0' encoding="ISO-8859-1" ?> <ServiceExceptionReport version="1.2.0" xmlns="​http://www.opengis.net/ogc" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/ogc ​http://schemas.opengis.net//wms/1.1.1/OGC-exception.xsd">

<ServiceException code="InvalidParameterValue" locator="version">msWCSDispatch(): WCS server error. WCS Server does not support VERSION 0.8.0. </ServiceException>

</ServiceExceptionReport>

[nsavard]

For reference the CITE tests are:

wcs1-0-0/basic_service_elements/version_numbering_and_negotiation/1 wcs1-0-0/basic_service_elements/version_numbering_and_negotiation/2 wcs1-0-0/basic_service_elements/version_numbering_and_negotiation/3 wcs1-0-0/basic_service_elements/version_numbering_and_negotiation/4

[tomkralidis]

This is where verison negotiaion would come in handy -- and probably a good reason to soundly implement #996 so that this ticket can take advantage.

[tomkralidis]

Norm: fixed in r7336. Can you check and confirm?

[nsavard]

Replying to tomkralidis:

Norm: fixed in r7336. Can you check and confirm?

Tom: When the version is not specified an exception is still thrown. All other cases work.

[nsavard]

Replying to nsavard:

Replying to tomkralidis:

Norm: fixed in r7336. Can you check and confirm?

Tom: When the version is not specified an exception is still thrown. All other cases work.

Tom: I made a mistake in the description of this ticket, it should read: A GetCapabilities request to a WCS 1.0.0 server without the version "number" should not return an exception

[tomkralidis]

Wierd. A WMS error is displayed.

Ah. The reason for this is because, since msWMSDispatch is the first dispatch called from mapows.c, msWMSDispatch checks for VERSION before testing whether it's a WMS request (i.e. service=WMS).

I modified mapwms.c such that the version is not tested UNTIL it is determined that service=WMS. This was done in r7352. I then tested against msautotest and had no issues (w.r.t. this fix).

I Norm: can you quickly test again?

[nsavard]

Replying to tomkralidis:

I modified mapwms.c such that the version is not tested UNTIL it is determined that service=WMS. This was done in r7352. I then tested against msautotest and had no issues (w.r.t. this fix).

I Norm: can you quickly test again?

I'm compiling a new MS and will test this.

[nsavard]

Replying to nsavard:

Replying to tomkralidis:

I modified mapwms.c such that the version is not tested UNTIL it is determined that service=WMS. This was done in r7352. I then tested against msautotest and had no issues (w.r.t. this fix).

I Norm: can you quickly test again?

I'm compiling a new MS and will test this.

Tom: I'm getting a WCS 1.1.1 capabilities document. It seems to work.

Question: Are the warnings intentional?

e.g.: WARNING: Optional metadata "ows_title" missing for ows:Title

[tomkralidis]

Replying to nsavard:

Replying to nsavard:

Replying to tomkralidis:

I modified mapwms.c such that the version is not tested UNTIL it is determined that service=WMS. This was done in r7352. I then tested against msautotest and had no issues (w.r.t. this fix).

I Norm: can you quickly test again?

I'm compiling a new MS and will test this.

Tom: I'm getting a WCS 1.1.1 capabilities document. It seems to work.

Question: Are the warnings intentional?

e.g.: WARNING: Optional metadata "ows_title" missing for ows:Title

Great! Yes, the warnings are intentional. Can we close this one?

[nsavard]

Replying to tomkralidis:

Replying to nsavard:

Replying to nsavard:

Replying to tomkralidis:

I modified mapwms.c such that the version is not tested UNTIL it is determined that service=WMS. This was done in r7352. I then tested against msautotest and had no issues (w.r.t. this fix).

I Norm: can you quickly test again?

I'm compiling a new MS and will test this.

Tom: I'm getting a WCS 1.1.1 capabilities document. It seems to work.

Question: Are the warnings intentional?

e.g.: WARNING: Optional metadata "ows_title" missing for ows:Title

Great! Yes, the warnings are intentional. Can we close this one?

Yes sure.