Mapserver fails to copy style and label attribute bindings on map->clone

[aalbarello]

When cloning a map, the new style and label attribute bindings introduced with MapServer 5.0 (ANGLE [item], SIZE [item] etc.) which are working correctly in the original map, fail to work in the resulting map.

This is due to the fact that, while the bindings member of the styleObj and labelObj struct is copied correctly, the numbindings member is missing from both msCopyLabel() and msCopyStyle() in mapcopy.c and therefore stays 0 in the cloned map.

Adding

MS_COPYSTELEM(numbindings);

to the two functions mentioned fixes this.

I'm attaching a diff against svn HEAD. Hopefully this can be backported in time for 5.0.1.

Thanks,

Andreas Albarello

[sdlime]

Fixed in both the 5.0 branch and the main trunk. Thanks for catching this.

Steve