WFS 1.0.0 GetFeature when a bbox partially enclosed a feature shall return this feature

Norm: I can't seem to reproduce this. Filter BBOX queries return features for partials on my test data here. Can you wrap up a small testcase and email to me?

Norm: thanks for the testcase. Can you send along the underlying dataset in the request (i.e. MPoints)? The mapfile points to a postgis db for this one. Perhaps you can run pgsql2shp and pass me a shapefile for testing?

Norm: thanks for emailing the data as shapefiles. I tried this again and can't reproduce. Here's the altered testcase: http://devgeo.cciw.ca/ms_tmp/mstrac-2443.tgz (you'll see that I commented out SHAPEPATH in the mapfile). Run ./req to run the testcase per this ticket.

What does your table for this layer look like in !PostGIS? Can you do a \dt and post the output?

I can try to load in a database and see if the behaviour changes.

After further testing it comes out that there is a problem when the requested layer is a PostGIS one. It returns the correct result when the MPoints layer is a shapefile layer. The MPoints layer contains only two points located at: (500325 500025,500375 500075) and is a multipoint object. When the bbox of the request is set to: (500375,500000 500400,500100), MapServer does not find the multipoint object. I trapped the debug log for this case (see case 1 below). Notice that in this case only one request is sent to the PostGIS db.

When the bbox is set to (500325,500000 500400,500100), MapServer finds the object. The debug log appears below as case 2. Notice that there are two requests sent by MapServer in this case.

I'll attach a test case. Case 1: [Wed Mar 19 15:36:10 2008].765795 msPOSTGISLayerOpen called datastatement: multi pointproperty from mpoints using unique pkey using SRID=32615 [Wed Mar 19 15:36:10 2008].766264 MSPOSTGISLayerOpen -- shared connection not av ailable. [Wed Mar 19 15:36:10 2008].778640 msConnPoolRegister(MPoints,dbname=cite-wfs100, 0x80c2fb0) [Wed Mar 19 15:36:10 2008].778770 msPOSTGISLayerFreeItemInfo called [Wed Mar 19 15:36:10 2008].778837 msPOSTGISLayerWhichShapes called [Wed Mar 19 15:36:10 2008].778964 msPOSTGISLayerParseData: unique column = pkey,

srid='32615', geom_column_name = multipointproperty, table_name=mpoints

[Wed Mar 19 15:36:10 2008].779927 query_string_0_6:DECLARE mycursor BINARY CURSO R FOR SELECT asbinary(force_collection(force_2d(multipointproperty)),'NDR'),pkey ::text from mpoints WHERE multipointproperty && setSRID('BOX3D(500375 500000,500 400 500100)'::BOX3D, 32615 ) [Wed Mar 19 15:36:10 2008].824388 msPOSTGISLayerFreeItemInfo called [Wed Mar 19 15:36:10 2008].824460 msPOSTGISLayerClose datastatement: multipointp roperty from mpoints using unique pkey using SRID=32615 [Wed Mar 19 15:36:10 2008].824497 msPOSTGISLayerClose -- closing query_result [Wed Mar 19 15:36:10 2008].824834 msConnPoolRelease(MPoints,dbname=cite-wfs100,0 x80c2fb0) [Wed Mar 19 15:36:10 2008].824892 msConnPoolClose(dbname=cite-wfs100,0x80c2fb0) [Wed Mar 19 15:36:10 2008].827212 msQueryByRect(): Search returned no results. N o matching record(s) found. [Wed Mar 19 15:36:10 2008].827290 msWFSGetFeature(): WFS server error. FLTApplyF ilterToLayer() failed [Wed Mar 19 15:36:10 2008].829662 msFreeMap(): freeing map at 0x8098fc8. [Wed Mar 19 15:36:10 2008].829728 msPOSTGISLayerClose datastatement: multipointp roperty from mpoints using unique pkey using SRID=32615 [Wed Mar 19 15:36:10 2008].829767 msPOSTGISLayerClose -- layerinfo is NULL

Case 2:

[Wed Mar 19 15:36:15 2008].332703 msPOSTGISLayerOpen called datastatement: multi pointproperty from mpoints using unique pkey using SRID=32615 [Wed Mar 19 15:36:15 2008].333178 MSPOSTGISLayerOpen -- shared connection not av ailable. [Wed Mar 19 15:36:15 2008].345561 msConnPoolRegister(MPoints,dbname=cite-wfs100, 0x8eb0fb0) [Wed Mar 19 15:36:15 2008].345715 msPOSTGISLayerFreeItemInfo called [Wed Mar 19 15:36:15 2008].345786 msPOSTGISLayerWhichShapes called [Wed Mar 19 15:36:15 2008].345916 msPOSTGISLayerParseData: unique column = pkey,

srid='32615', geom_column_name = multipointproperty, table_name=mpoints

[Wed Mar 19 15:36:15 2008].346871 query_string_0_6:DECLARE mycursor BINARY CURSO R FOR SELECT asbinary(force_collection(force_2d(multipointproperty)),'NDR'),pkey ::text from mpoints WHERE multipointproperty && setSRID('BOX3D(500325 500000,500 400 500100)'::BOX3D, 32615 ) [Wed Mar 19 15:36:15 2008].393538 msPOSTGISLayerFreeItemInfo called [Wed Mar 19 15:36:15 2008].393610 msPOSTGISLayerClose datastatement: multipointp roperty from mpoints using unique pkey using SRID=32615 [Wed Mar 19 15:36:15 2008].393670 msPOSTGISLayerClose -- closing query_result [Wed Mar 19 15:36:15 2008].394012 msConnPoolRelease(MPoints,dbname=cite-wfs100,0 x8eb0fb0) [Wed Mar 19 15:36:15 2008].394070 msConnPoolClose(dbname=cite-wfs100,0x8eb0fb0) [Wed Mar 19 15:36:15 2008].449302 msPOSTGISLayerOpen called datastatement: multi pointproperty from mpoints using unique pkey using SRID=32615 [Wed Mar 19 15:36:15 2008].449376 MSPOSTGISLayerOpen -- shared connection not av ailable. [Wed Mar 19 15:36:15 2008].458435 msConnPoolRegister(MPoints,dbname=cite-wfs100, 0x8eb10e0) [Wed Mar 19 15:36:15 2008].458546 msPOSTGISLayerFreeItemInfo called [Wed Mar 19 15:36:15 2008].458585 in msPOSTGISLayerGetItems (find column names) [Wed Mar 19 15:36:15 2008].458666 msPOSTGISLayerParseData: unique column = pkey,

srid='32615', geom_column_name = multipointproperty, table_name=mpoints

[Wed Mar 19 15:36:15 2008].465759 msPOSTGISLayerInitItemInfo called [Wed Mar 19 15:36:15 2008].466009 msPOSTGISLayerGetShape called for record = 1 [Wed Mar 19 15:36:15 2008].466076 msPOSTGISLayerParseData: unique column = pkey,

srid='32615', geom_column_name = multipointproperty, table_name=mpoints

[Wed Mar 19 15:36:15 2008].466208 msPOSTGISLayerGetShape: DECLARE mycursor2 BINA RY CURSOR FOR SELECT "id"::text,"pkey"::text,asbinary(force_collection(force_2d( multipointproperty)),'NDR') from mpoints WHERE pkey = 1 [Wed Mar 19 15:36:15 2008].511557 msPOSTGISLayerFreeItemInfo called [Wed Mar 19 15:36:15 2008].511650 msPOSTGISLayerClose datastatement: multipointp roperty from mpoints using unique pkey using SRID=32615 [Wed Mar 19 15:36:15 2008].511689 msPOSTGISLayerClose -- query_result is NULL [Wed Mar 19 15:36:15 2008].511721 msConnPoolRelease(MPoints,dbname=cite-wfs100,0 x8eb10e0) [Wed Mar 19 15:36:15 2008].511761 msConnPoolClose(dbname=cite-wfs100,0x8eb10e0) [Wed Mar 19 15:36:15 2008].514338 msFreeMap(): freeing map at 0x8e86fc8. [Wed Mar 19 15:36:15 2008].514438 msPOSTGISLayerClose datastatement: multipointp roperty from mpoints using unique pkey using SRID=32615 [Wed Mar 19 15:36:15 2008].514478 msPOSTGISLayerClose -- layerinfo is NULL

This is the test case for comment:7

I made a formatting mistake when pasting the MapServer log output for the two cases in comment:7. Nevertheless you can find a copy of this output in the attachement, in the file named "output.log".

Paul: Can you have a look to this one because this is related to PostGis?? The main problem is that the PostGis? layers do not have the same behaviour as the shapefile layers when a bbox partially enclosed a feature.

OK, I have duplicated the test case behavior. I'll see if I can track down the root cause before rejecting the ticket as not worth fixing :)

Tentative fix

nsavard, could you test the attached patch, I'm pretty sure it's the answer.

Paul: I'll check. Thanks.

For the record the CITE test used to output the bug is: wfs:test1.0.0-basic-getfeature-filter-spatialoperators-bbox-get-10 on thhttp://cite.opengeospatial.org/teamengine/ Web page.

Paul: I checked and this issue is fixed. Thank you again.

Committed as of r7558.

Committed to branch-5-0 as of r7559.