Ticket #2396 (closed defect: fixed)

Opened 6 years ago

Last modified 5 years ago

iconv configure tests don't work on OSX 10.5 64bit

Reported by: kyngchaos Owned by: dmorissette
Priority: normal Milestone: 5.2 release
Component: Build Problems Version: 5.0
Severity: major Keywords:
Cc:

Description

First, libgd uses iconv_open() and iconv_close(), not libiconv_open() and libiconv_close(), so there is no need to test for libiconv_*() functions. Second, the 64bit version libiconv on OSX 10.5 does not include libiconv_*(), just inconv_*(), while the 32bit OSX libiconv includes both.

MapServer configure tests for libiconv_*() in libiconv, and strangely it tests for iconv_*() in libc.

So, on 64bit OSX 10.5, the iconv test fails.

Change History

Changed 5 years ago by dmorissette

  • owner changed from mapserverbugs to dmorissette
  • milestone changed from 5.0.1 release to 5.2 release

I have to admit I'm scared of changing this behavior, especially in a bugfix release, because of all the possible combinations of iconv configs and all the trouble we've had trying to get this working right in previous releases.

Pushing to 5.2, and please bug me again if you don't see any activity on this in the next month or two.

Changed 5 years ago by dmorissette

  • status changed from new to closed
  • resolution set to fixed

I believe the reason why we check for libiconv_*() functions (and not iconv_*) in libiconv is that in some cases iconv.h may '#define iconv_open libiconv_open'... and in this case you end up with only libiconv_*() symbols and no iconv_*(). However code using iconv_*() still works through the #define'd iconv_* mappings.

In r7692 (SVN trunk, will be in 5.0.2-beta2) I've added an extra test to look for iconv_*() in libiconv, hopefully that should solve the issue in the case you describe without affecting anything else.

Closing as fixed. Please reopen if that doesn't work for you.

Note: See TracTickets for help on using tickets.