Opened 17 years ago

Last modified 13 years ago

#2319 new defect

Support for named styles in mapfile

Reported by: dmorissette Owned by: sdlime
Priority: normal Milestone: 6.0 release
Component: MapServer C Library Version: unspecified
Severity: normal Keywords:
Cc: crschmidt, sderle, jmckenna

Description (last modified by dmorissette)

crschmidt submitted a patch to ticket #1280 to support named styles in a mapfile, but since #1280 is about named styles in OGC SLD (a different beast), we are moving this patch to its own ticket here.

crschmidt wrote:

Old, old patch (5-2006) from Schuyler implementing named styles, which we just found when cleaning something up. Attaching patch here so it doesn't get lost. i think schuyler plans on doing some cleanup here, but at least it's here for the future regardless.

sderle wrote:

The patch works slightly better if you run patch with -F3. The idea was to allow STYLE blocks at the top level of the map file, with NAME directives to assign names to them. Then, in the LAYER blocks, one would simply be able to say "STYLE stylename" instead of having a STYLE block. Additionally, I added the INHERITS directive, which imports the style definitions from a named style into the current STYLE block, making it possible to "subclass" named styles. Please let me know if this ticket needs any attention at all on my part to move forward. Thanks!

Attachments (2)

mapserver-named-styles-2.patch (7.8 KB ) - added by dmorissette 17 years ago.
patch from schuyler
ms-rfc-54.rst (5.5 KB ) - added by sderle 14 years ago.
incomplete draft RFC on named styles

Download all attachments as: .zip

Change History (10)

by dmorissette, 17 years ago

patch from schuyler

comment:1 by dmorissette, 17 years ago

Description: modified (diff)

comment:2 by sdlime, 16 years ago

Man, I doubt the patch will apply given all the change. It also looked as there was intent to further refine the patch. Any comments? Otherwise I'm inclined to move to a 5.4 target.

Steve

comment:3 by dmorissette, 16 years ago

As this is a non-trivial change, and actually a new functionality I think it would deserve at a minimum a discussion on the -dev list (if not a RFC), so I agree with pushing this to 5.4.

comment:4 by sdlime, 16 years ago

Milestone: 5.2 release5.4 release

comment:5 by sdlime, 14 years ago

Milestone: 5.6 release6.0 release

Schuyler/Dan: I thought we sketched out a potential roadmap for block references at the code spring in Toronto but I didn't see it in the notes on the trac wiki. I don't suppose either of you kept anything? I believe we talked about expanding things beyond styles to include labels, etc... I'd really like to get this into 6.0 planning.

Steve

in reply to:  5 comment:6 by sderle, 14 years ago

Steve, I started work on an RFC and doing the job right proved to be more involved than I've had time to devote since. I'm attaching my incomplete RFC draft to this ticket in case anyone has the time and motivation to pursue it (or help me finish it).

by sderle, 14 years ago

Attachment: ms-rfc-54.rst added

incomplete draft RFC on named styles

comment:7 by sdlime, 14 years ago

Thanks Schuyler: This is what I was looking for. I'll take the next step of posting and at least one pass at refining it.

Steve

comment:8 by jmckenna, 13 years ago

Cc: jmckenna added
Note: See TracTickets for help on using tickets.