Need to return MS_SUCCESS/MS_FAILURE in msSLDParseRasterSymbolizer()

[dmorissette]

While working on ticket #302, I noticed that msSLDParseRasterSymbolizer() in mapogcsld.c has a void return type and doesn't return any indication of success/failure so I am unable to propagate possible errors to the caller.

msSLDParseRasterSymbolizer() needs to be fixed to return MS_SUCCESS/MS_FAILURE and the callers need to be modified to check its return value and propagate error situations to their own callers, etc.

[dmorissette]

The same issue was found in msSLDParseLineSymbolizer(), msSLDParsePolygonSymbolizer(), msSLDParsePolygonSymbolizer(), msSLDParsePointSymbolizer() and msSLDParseTextSymbolizer

[aboudreault]

I have modified SLD functions to return proper values. However, I haven't modified the function calls. They were not checking the return values and still don't.

Assefa, will let you close the ticket if everything is ok or let me know after you revisited the ticket if there are other issues you me to fix.

Fixed and committed r9611.

[assefa]

Thanks Alan, I will give it a look early next week and close.