Opened 17 years ago

Closed 16 years ago

#2163 closed defect (fixed)

Use dynamic allocation for array of httpRequestObj in mapdraw.c

Reported by: dmorissette Owned by: dmorissette
Priority: normal Milestone: 5.2 release
Component: WMS Client Version: 5.0
Severity: normal Keywords:
Cc:

Description

While working on r6356 of mapdraw.c (ticket #302), I realized that always allocating the array of httpRequestObj was not optimal.

We should use a msGrowRequestArray() method similar to what is used for the layers, classes, etc to allocate/grow the array only on demand. This would save some wasted memory for maps that don't use any OWS connections.

Note that we may have to turn the "httpRequestObj *pasOWSReqInfo" into a "httpRequestObj papsOWSReqInfo" to be real safe.

Change History (2)

comment:1 by dmorissette, 17 years ago

Milestone: 5.0 release → 5.2 release
Owner: changed from mapserverbugs to dmorissette

The current situation is no worse than what we had in previous releases, so we'll keep this enhancement for 5.2.

comment:2 by dmorissette, 16 years ago

Resolution: → fixed
Status: new → closed

This was fixed in r7583 (ticket #2615) by counting the number of WMS/WFS client layers and pre-allocating an array of exactly the right size.

Note: See TracTickets for help on using tickets.