AGG palette formatoption requires absolute path

[jmckenna]

Relative paths to the AGG palette file do not work:

OUTPUTFORMAT
    NAME "agg/png24"
    MIMETYPE "image/png; mode=24bit"
    DRIVER "AGG/PNG"
    EXTENSION "png"
    IMAGEMODE "RGB"
    FORMATOPTION "PALETTE_FORCE=TRUE"
    FORMATOPTION "PALETTE=palette.txt"  
END 

causes this error: msImageCreateWithPaletteGD(): Unable to access file. Error opening palette file palette.txt

It should be relative to the location of the mapfile.

[sdlime]

I agree and would have set it up that way if it were straightforward. Problem is that the image handling is basically mapfile independent and I don't have access to the stored path from an image format object. Not sure how best to handle...

Also changing component since this isn't specific to AGG.

Steve

[hobu]

Pushing this forward to 5.2, maybe we can figure out a clean way to deal with it then.

[sdlime]

We'll need to stuff the map path in the image object some place OR pass mapObj's around in places we haven't in the past.

Steve

[sdlime]

Anybody have ideas on how to best address? I see at least three options:

1 - add a new structure member, a pointer back to the parent mapObj to outputFormatObj's 2 - add a new structure member (mappath) to outputFormatObj's to hold the value of mappath from the initializing mapObj 3 - add code to mapfile.c so that mappath is added as a format option in cases where PALETTE= is found.

1 is something we do elsewhere (e.g. layers) and would keep the outputFormatObj in sync with the mapObj and is probably the easiest to implement.

Thoughts?

Steve

[warmerdam]

Steve,

What about changing msSaveImage() to pass the mapObj * down into msSaveImageGD() and msSaveImageGDCtx()? msSaveImageGDAL() already requires the mapObj.

I'm not keen on "back pointers" to the map in objects like the outputFormatObj because they are tricky to keep valid when things are moved around.