CLASSITEMs are no longer case insensitive

[hobu]

As a result of the reworking that combined msSDELayerGetItems,
msSDELayerInitItemInfo, and msSDELayerCreateItems, CLASSITEMs that do not have
the same case as the column names no longer work.  This needs to be fixed before
the release.

[banders@…]

Added myself to the CC list.

[hobu]

string2list in maplayer.c needs to be doing strcasecmp instead of strcmp, I think.

[hobu]

diff -r1.114 maplayer.c 329c329 < if(strcmp(list[i], string) == 0) { ---

if(strcasecmp(list[i], string) == 0) {

[hobu]

diff -r1.114 maplayer.c
329c329
<     if(strcmp(list[i], string) == 0) { 
---
>     if(strcasecmp(list[i], string) == 0) { 

[hobu]

I also added a check in mapsde.c to see if msWhichItems tacks another item onto the later->items list because it couldn't find it. The way SDE works now, *all* of the items descriptions are gotten from the table(s) and put on the list. We should consider reworking or even removing msWhichItems if it existed only to server SDE's previous behavior.

[hobu]

Steve,

Can patch be applied to string2list?

Howard

[sdlime]

I think the case insensitive match should be ok. Everything else is already that way. Can you apply and try?

steve

[hobu]

r6571 applies the change...

[hobu]

How can we test that this didn't have any bad effects?

[sdlime]

Run a few mapfiles with postgis, shapefile and OGR sources and see if anything breaks... ;-)

[hobu]

Haven't found any problems. We can reopen if something shows up.