Opened 17 years ago
Closed 15 years ago
#2066 closed defect (fixed)
shp2img command line documentation (usage message)
Reported by: | Owned by: | tomkralidis | |
---|---|---|---|
Priority: | high | Milestone: | 5.4 release |
Component: | Command Line Utilties | Version: | 4.10 |
Severity: | normal | Keywords: | |
Cc: | sdlime |
Description (last modified by )
Below, my comments have ">", and Warmerdam's reply doesn't. I'm not sure if he implemented all my ideas. > $ shp2img > Say: > Syntax: shp2img -m mapfile [-o image] [-e minx miny maxx maxy] > [-l "layer1[ layer2]..."] [-i format] > [Note I have changed all both lines] > Else also no one will ever know how to add more than one layer and > will try commas. Also -l NON_EXISTENT doesn't raise an error. > Also besides just syntax, it should say Purpose: ... as there is no > man page. Same for its sibling programs. > Also add options to turn off layers. I have updated the docs for -l. I never would have guessed it works as it does. There is some sort of documentation for the utilities on the MapServer plone site.
Change History (7)
comment:1 by , 16 years ago
Cc: | added |
---|---|
Milestone: | → 5.2 release |
Owner: | changed from | to
comment:2 by , 16 years ago
Committed to trunk in r7301.
- cleaned up usage text to align with flags, added those that were missing
- added "Purpose" to usage text
- checked for -l NON_EXISTENT, exit if layer not found
- similarly cleaned up and check for layer not found for shp2pdf.c as well.
- updated http://mapserver.gis.umn.edu/docs/reference/utilityreference/shp2img
- updated HISTORY.TXT
- no changes to msautotest in this regard
Steve: what is the -d flag for exactly? It's in the code but not documented. If you provide me an explanation on that I will update the usage text.
comment:3 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Steve confirmed on irc that -d is to change the DATA value for a layername on the fly.
Now updated in r7322. Closing.
comment:4 by , 15 years ago
Description: | modified (diff) |
---|---|
Resolution: | fixed |
Severity: | minor → normal |
Status: | closed → reopened |
The layer test doesn't work for layers that are STATUS DEFAULT. The layer_found logic in the patch then gets broken when encountering a DEFAULT layer.
comment:5 by , 15 years ago
Milestone: | 5.2 release → 5.4 release |
---|
comment:6 by , 15 years ago
Fixed in r8489. Does an initial check against all incoming layers passed, regardless of their LAYER.STATUS.
comment:7 by , 15 years ago
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Backported to branch-5-2 in r8494. Closing.
I'll take this one (have a working fix).