Opened 17 years ago

Closed 17 years ago

#2045 closed defect (fixed)

[MapServer C Library] Include parsing not closing Symbols (?)

Reported by: jmckenna@… Owned by: sdlime
Priority: highest Milestone: 5.0.1 release
Component: MapServer C Library Version: 5.0
Severity: normal Keywords:
Cc: assefa@…

Description (last modified by dmorissette)

Assefa discovered an interesting one (bare with me as I try to explain it, as I
bet at first you'll think it is a mapscript issue I'm sure):

- in PHP/Mapscript, a loop that simply creates a map object, with a mapfile that
has an include, AND has a symbol file, fails
- the odd thing is that if you add an extra END in the symbol file it does not
fail anymore (?)

Here is a tiny test case (http://www2.dmsolutions.ca/netbin/include-bug.zip) 1KB
  - run test.php

(i'm not sure if this is related to bug#2013 - font handling with includes)

PHP Script
==========

<?php
if (!extension_loaded("MapScript")) 
     dl("php_mapscript.dll");

for ($i=0; $i<4; $i++)
{
  $oSourceMap = ms_newmapobj('./test.map');
  if ($oSourceMap)
    echo "success <br>\n";
  else
    echo "failure <br>\n";
}
?>

Mapfile
=======

NAME include-test
STATUS ON
SIZE 400 300
SYMBOLSET ./symbols.sym
EXTENT -180 -90 180 90
UNITS DD
IMAGECOLOR 255 255 255

DEBUG on

WEB
  IMAGEPATH "/ms4w/tmp/ms_tmp/" 
  IMAGEURL "/ms_tmp/"
END

INCLUDE "./include.lay"

END # Map File

Include File
============

LAYER
  NAME test
  TYPE POINT
  STATUS ON
  FEATURE
    POINTS
       69.43 35.15
    END
  END
  CLASS
    STYLE
      COLOR 0 0 250
      SYMBOL 'circle'
      SIZE 100
    END
  END
END # layer

Symbol File
===========

Symbol
  Name 'circle'
  Type ELLIPSE
  Filled TRUE
  Points
    1 1
  END
END

Testing Environment
===================

MapServer 4.10.1
windows

Change History (9)

comment:1 by jmckenna@…, 17 years ago

Cc: mapserver-bugs@… added
no response.  Did I not explain this clear enough?

comment:2 by sdlime, 17 years ago

Status: newassigned
This is the first I've heard of the bug, original message never made it so I 
haven't had a chance to look yet.

Steve

comment:3 by dmorissette, 17 years ago

Milestone: 5.0 release

comment:4 by assefa, 17 years ago

Cc: assefa@… added

comment:5 by dmorissette, 17 years ago

Description: modified (diff)

Jeff, Assefa, would you be able to test this again with the latest beta? Some fixes have been done in that area in 5.0 and we'd need to know whether this is still an issue.

comment:6 by sdlime, 17 years ago

I'll wait until there is confirmation...

Steve

comment:7 by assefa, 17 years ago

It seemed to be fixed for me using MapServer svn using the test data.

Jeff please confirm and close.

comment:8 by sdlime, 17 years ago

Milestone: 5.0 release5.0.1 release

Moving to 5.0.1 without test confirmation...

Steve

comment:9 by jmckenna, 17 years ago

Resolution: fixed
Status: assignedclosed

Tested successfully (no problems) with mapserver-5.0-rc2.

Note: See TracTickets for help on using tickets.