Opened 17 years ago

Closed 15 years ago

#2006 closed defect (fixed)

Join with postgis table

Reported by: oven38@… Owned by: pramsey
Priority: high Milestone:
Component: PostGIS Interface Version: 4.10
Severity: normal Keywords:
Cc:

Description (last modified by warmerdam)

Join with postgis table noz work when FROM and TO items are charater type.

mappostgresql.c line 336 must change to 
        sprintf(sql, "SELECT %s FROM %s WHERE %s = '%s'", columns, join->table,
join->to, joininfo->from_value);

 thanks

Change History (7)

comment:1 by sdlime, 17 years ago

Cc: steve.lime@… added
Component: MapServer C LibraryPostGIS Interface
Owner: changed from sdlime to mapserver-bugs@…
And that will break numeric joins (which might be more common). Need to examine
the type of the 'to' column ideally. Could also try the quotes if not using them
throws an error. I'm changing the component to the PostGIS Interface since I
believe Paul wrote the join stuff and see if they have any ideas.

Steve

comment:2 by refractions, 17 years ago

Pretty sure we didn't do the postgresql joining. Putting in the ticks should actually work, postgresql is 
pretty clever about appropriately casting things.

comment:3 by sdlime, 17 years ago

Status: newassigned
Wonder who did? Anyway, cool, I'll make that change then and test it out.

Steve

comment:4 by warmerdam, 17 years ago

Description: modified (diff)

Steve,

Are you still planning to fix this? If you are too busy, feel free to reassign it to me, and I'll take a crack at it.

comment:5 by sdlime, 17 years ago

Please take it if you have time. It should be easy enough to test. I don't have Postgres running on my mac but I could test at work if necessary.

Steve

comment:6 by pramsey, 15 years ago

Owner: changed from mapserver-bugs@… to pramsey
Status: assignednew

comment:7 by pramsey, 15 years ago

Resolution: fixed
Status: newclosed

Fixed in 5.4 branch at r9049 and in trunk at r9050.

Note: See TracTickets for help on using tickets.