Ticket #1926 (closed defect: worksforme)

Opened 7 years ago

Last modified 3 years ago

[MapServer-msautotest]Some tests run only on Linux

Reported by: nsavard@… Owned by: warmerdam
Priority: high Milestone:
Component: msautotest Version: 4.10
Severity: normal Keywords:
Cc:

Description (last modified by warmerdam) (diff)

There are actually five tests in wms_time_pattern.map that run only on Linux
because of a different behaviour of strptime function on Windows.  These tests
are:  wms_time_pattern1a.png, wms_time_pattern1b.png, wms_time_pattern1c.png,
wms_time_pattern1d.png and wms_time_pattern2d.png.

How should msautotest handle this case?

This is a note done by Assefa:
Pattern "%Y%m%d"  : does not work (on windows at least) : problem with strptime
(parsing of the year is done like this (line 408) ret = strtol (buf, &s, 10)
(where buffer =20040101 so the return year is 20040101

Change History

Changed 7 years ago by nsavard@…

See bug 970.

Changed 7 years ago by fwarmerdam

Normand, 

Is there another date format we could use that would work everywhere?
If so, that might be better, and we could add a note in bug 970 to add
a YYYYMMDD casein msautotest once the bug is fixed.


Changed 7 years ago by nsavard@…

YYYYMMDD is just a special case that I wanted to test because it was available
to the user.  But I agree that for now we could remove these five tests. I could
keep these tests in the map file and remove the " RUN_PARMS:" to avoid their
execution.  There are these two existing format already:  "%Y-%m-%d" and
"%Y-%m-%dZ".

I would add a note to bug 970.

Changed 3 years ago by warmerdam

  • description modified (diff)

Normand,did you disable these tests? If so, can we close this ticket?

Changed 3 years ago by warmerdam

  • status changed from new to closed
  • resolution set to worksforme

I'm seeing all the wms_time_pattern*.map tests succeed on windows and linux, so I assume the problem tests were disabled.

Changed 3 years ago by nsavard

Frank sorry for the delay. I'll check that to be sure but It sounds like a good assumption.

Note: See TracTickets for help on using tickets.